You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/11 17:53:37 UTC
[GitHub] [airflow] blcksrx opened a new issue #15322: Support WebHook Alerting
blcksrx opened a new issue #15322:
URL: https://github.com/apache/airflow/issues/15322
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
**Description**
It's a good idea to have such a feature like we already have it `email_on_failure` also for webhooks that lets the users configured it once to alert in Slack, Mattermost, etc. I know it's possible to write a callback function and set the `on_failure_callback` but it needs to each user develop it for his/her goods. In addition, supporting this provides a better user experience
**Are you willing to submit a PR?**
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #15322:
URL: https://github.com/apache/airflow/issues/15322#issuecomment-817714153
This looks like a feature that requires a discussion of the body format that we will be sending in request. Could you please prepare a document and then start discussions on the mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
ashb closed issue #15322:
URL: https://github.com/apache/airflow/issues/15322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15322:
URL: https://github.com/apache/airflow/issues/15322#issuecomment-817717200
somehow related to https://github.com/apache/airflow/issues/8686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
blcksrx commented on issue #15322:
URL: https://github.com/apache/airflow/issues/15322#issuecomment-818004925
@mik-laj is this good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
blcksrx commented on issue #15322:
URL: https://github.com/apache/airflow/issues/15322#issuecomment-818002994
I would like to present a new feature in airflow. It's a good idea to support webhooks triggers for notifying users about their tasks.
we can do it by providing it in a way that I could supports software like Slack, MatterMost, Discord, MS Teams. this software currently uses by a wide range of international users.
This feature provides a better UX for our users and also reduces efforts for every company/user who uses airflow to write their own callbacks.
Here is my initials idea:
- Changes in the `default_args`:
- add new entry: `webhook_on_failure: bool`
- add new entry: `webhook_on_retry: bool`
- add new entry: `webhook_on_success: bool`
- add new entry: `channels: List[str]` (List of channels)
- add new entry: `mentions: List[str]` (List of users to mention)
- Changes in the `airflow.cfg`:
- add new seciont like `[webhook]` for Slack, etc. configuration.
- Message templates:
I would like to do it like the Prometheus alerting template.
About message templates, I mean something like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15322:
URL: https://github.com/apache/airflow/issues/15322#issuecomment-849622265
Two related issues: https://github.com/apache/airflow/issues/8686 https://github.com/apache/airflow/issues/12611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blcksrx commented on issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
blcksrx commented on issue #15322:
URL: https://github.com/apache/airflow/issues/15322#issuecomment-817719096
@mik-laj Thanks for your comment. I will do it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #15322:
URL: https://github.com/apache/airflow/issues/15322#issuecomment-817714750
Related: https://github.com/apache/airflow/issues/14622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #15322: Support WebHook Alerting
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #15322:
URL: https://github.com/apache/airflow/issues/15322#issuecomment-849625873
Closing in favour of the more general purpose https://github.com/apache/airflow/issues/12611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org