You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jianxia Chen <jc...@pivotal.io> on 2015/12/18 21:01:44 UTC
Review Request 41563: Fix some bugs found in the network partition
tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41563/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, and Jason Huynh.
Repository: geode
Description
-------
Patch based on a team discussion to solve two issues on network partition tests:
1) Surviving side member is unexpectedly forced out
2) Splitbrain scenario on startup of locators
For the first issue, the fix turns on the TCP_NODELAY flag for fast suspect member final check process.
For the second issue, increase the timeout for locator startup.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 8c38ba6
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java 8b9347e
Diff: https://reviews.apache.org/r/41563/diff/
Testing
-------
Network partition tests.
Thanks,
Jianxia Chen
Re: Review Request 41563: Fix some bugs found in the network
partition tests
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41563/#review111250
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On Dec. 18, 2015, 8:01 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41563/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 8:01 p.m.)
>
>
> Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, and Jason Huynh.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Patch based on a team discussion to solve two issues on network partition tests:
>
> 1) Surviving side member is unexpectedly forced out
>
> 2) Splitbrain scenario on startup of locators
>
> For the first issue, the fix turns on the TCP_NODELAY flag for fast suspect member final check process.
>
> For the second issue, increase the timeout for locator startup.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java 8c38ba6
> gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/tcpserver/TcpClient.java 8b9347e
>
> Diff: https://reviews.apache.org/r/41563/diff/
>
>
> Testing
> -------
>
> Network partition tests.
>
>
> Thanks,
>
> Jianxia Chen
>
>