You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/03 05:20:59 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #8038: Prevent
'main' database connection creation
codecov-io commented on issue #8038: Prevent 'main' database connection creation
URL: https://github.com/apache/incubator-superset/pull/8038#issuecomment-527308188
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8038?src=pr&el=h1) Report
> Merging [#8038](https://codecov.io/gh/apache/incubator-superset/pull/8038?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee24539bd2dc0c66a204015ebcb957a924a55452?src=pr&el=desc) will **increase** coverage by `7.6%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8038?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8038 +/- ##
==========================================
+ Coverage 66.06% 73.67% +7.6%
==========================================
Files 479 115 -364
Lines 22930 12036 -10894
Branches 2524 0 -2524
==========================================
- Hits 15148 8867 -6281
+ Misses 7648 3169 -4479
+ Partials 134 0 -134
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8038?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `87.95% <ø> (-0.11%)` | :arrow_down: |
| [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `74% <0%> (-0.3%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.03% <0%> (-0.22%)` | :arrow_down: |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `34.09% <100%> (-3.25%)` | :arrow_down: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | |
| [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | | |
| [...ets/src/dashboard/components/dnd/DragDroppable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvRHJhZ0Ryb3BwYWJsZS5qc3g=) | | |
| [...c/visualizations/deckgl/layers/Polygon/Polygon.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbi5qc3g=) | | |
| ... and [361 more](https://codecov.io/gh/apache/incubator-superset/pull/8038/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8038?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8038?src=pr&el=footer). Last update [ee24539...ee0614f](https://codecov.io/gh/apache/incubator-superset/pull/8038?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org