[GitHub] [rocketmq] vongosling commented on a change in pull request #1415: [ISSUE 504] Polish 'No route info of this topic' exception

[GitBox <gi...@apache.org>]

vongosling commented on a change in pull request #1415: [ISSUE 504] Polish 'No route info of this topic' exception
URL: https://github.com/apache/rocketmq/pull/1415#discussion_r317346987
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/impl/factory/MQClientInstance.java
 ##########
 @@ -676,10 +677,13 @@ public boolean updateTopicRouteInfoFromNameServer(final String topic, boolean is
                     } else {
                         log.warn("updateTopicRouteInfoFromNameServer, getTopicRouteInfoFromNameServer return null, Topic: {}", topic);
                     }
-                } catch (Exception e) {
+                } catch (MQClientException e) {
                     if (!topic.startsWith(MixAll.RETRY_GROUP_TOPIC_PREFIX) && !topic.equals(MixAll.AUTO_CREATE_TOPIC_KEY_TOPIC)) {
                         log.warn("updateTopicRouteInfoFromNameServer Exception", e);
                     }
+                } catch (RemotingException e) {
+                    log.warn("updateTopicRouteInfoFromNameServer Exception", e);
 
 Review comment:
   Please consider log and throw action as a whole when an exception occurs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services