[GitHub] [activemq] maxfortun commented on pull request #751: Added activemq-redis-store

[GitBox <gi...@apache.org>]

maxfortun commented on pull request #751:
URL: https://github.com/apache/activemq/pull/751#issuecomment-1070961251


   Clarification: 
   
   The code was copied and augmented with Redisson client from [InMemoryJobScheduler](https://github.com/apache/activemq/tree/main/activemq-broker/src/main/java/org/apache/activemq/broker/scheduler/memory)
   
   The dir/file structure/layout were modeled after leveldb, as I thought that's how optional components are packaged into activemq.
   
   Unlike leveldb, Redis is a standalone service, thus all processing is happening outside of activemq process space. It's closer to JDBC than to leveldb.
   
   If you believe that Job Scheduler Store and Persistence Adaptors should be packaged differently, I can rename/change the dir structure.
   
   Ultimately, if there was interest and traction by activemq maintainers, the intent was to reach out to redis people and see if they want to contribute. 
   
   > On Mar 17, 2022, at 4:16 AM, Lucas Tétreault ***@***.***> wrote:
   > 
   > 
   > Correct but I wasn't clear: it seems to be just a job scheduler store, not a message store. So for me it makes sense to be renamed as it's not a store but "just" a job scheduler store
   > 
   > Agreed.
   > 
   > —
   > Reply to this email directly, view it on GitHub <https://github.com/apache/activemq/pull/751#issuecomment-1070521974>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNVZ5DB4SW3NIPPTO4JBI3VALS6JANCNFSM5M36KMRA>.
   > You are receiving this because you were mentioned.
   > 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org