You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "qijiale76 (via GitHub)" <gi...@apache.org> on 2023/11/23 12:14:26 UTC
[PR] [#1327]feat(tez): Support combine operation in sort for tez engine. [incubator-uniffle]
qijiale76 opened a new pull request, #1328:
URL: https://github.com/apache/incubator-uniffle/pull/1328
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Support combine operation in sort for tez engine.
### Why are the changes needed?
Fix: #1327
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
new UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1327]feat(tez): Support combine operation in sort for tez engine. [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1328:
URL: https://github.com/apache/incubator-uniffle/pull/1328#issuecomment-1824344124
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1328?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`51e02d0`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/51e02d0539786b3888832c16a4248bc2ded44513?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.47% compared to head [(`6dd9778`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1328?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 53.82%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #1328 +/- ##
============================================
+ Coverage 53.47% 53.82% +0.35%
+ Complexity 2695 2167 -528
============================================
Files 411 334 -77
Lines 23644 15091 -8553
Branches 2006 1389 -617
============================================
- Hits 12643 8123 -4520
+ Misses 10225 6515 -3710
+ Partials 776 453 -323
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1328?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org