You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org> on 2010/09/13 00:21:32 UTC
[jira] Created: (QPID-2857) [Java] Running FindBugs against Java
codebase reveals room for improvement
[Java] Running FindBugs against Java codebase reveals room for improvement
--------------------------------------------------------------------------
Key: QPID-2857
URL: https://issues.apache.org/jira/browse/QPID-2857
Project: Qpid
Issue Type: Bug
Components: Java Broker, Java Broker MessageStore - DerbyStore, Java Client, Java Clustering, Java Common, Java Management : CLI Tool, Java Management : JMX Console, Java Management : JMX Interface, Java Management : QMan, Java Management : QMF, Java Performance Tests, Java Tests, Java Tools
Affects Versions: 0.6
Reporter: Rob Godfrey
Assignee: Rob Godfrey
Fix For: 0.7
FindBugs (http://findbugs.sourceforge.net/) is a program which uses static analysis to look for bugs in Java code
Ideally we should incorporate Findbugs into our ant build such that we can be informed when new critical issues may have been introduced.
In the interim findbugs can be run manually.
Where critical issues are discovered by findbugs we should correct these
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2857) [Java] Running FindBugs against Java
codebase reveals room for improvement
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-2857:
---------------------------------
Attachment: report.html.zip
> [Java] Running FindBugs against Java codebase reveals room for improvement
> --------------------------------------------------------------------------
>
> Key: QPID-2857
> URL: https://issues.apache.org/jira/browse/QPID-2857
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Broker MessageStore - DerbyStore, Java Client, Java Clustering, Java Common, Java Management : CLI Tool, Java Management : JMX Console, Java Management : JMX Interface, Java Management : QMan, Java Management : QMF, Java Performance Tests, Java Tests, Java Tools
> Affects Versions: 0.6
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: 0.7
>
> Attachments: findbugs.html, findbugs.html, report.html.zip
>
>
> FindBugs (http://findbugs.sourceforge.net/) is a program which uses static analysis to look for bugs in Java code
> Ideally we should incorporate Findbugs into our ant build such that we can be informed when new critical issues may have been introduced.
> In the interim findbugs can be run manually.
> Where critical issues are discovered by findbugs we should correct these
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2857) [Java] Running FindBugs against Java
codebase reveals room for improvement
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey updated QPID-2857:
------------------------------
Attachment: findbugs.html
Output of running FindBugs against the non-test Java code for svn revision 996392.
High Priority Warnings: 654
Medium Priority Warnings: 577
Total Warnings: 1231
> [Java] Running FindBugs against Java codebase reveals room for improvement
> --------------------------------------------------------------------------
>
> Key: QPID-2857
> URL: https://issues.apache.org/jira/browse/QPID-2857
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Broker MessageStore - DerbyStore, Java Client, Java Clustering, Java Common, Java Management : CLI Tool, Java Management : JMX Console, Java Management : JMX Interface, Java Management : QMan, Java Management : QMF, Java Performance Tests, Java Tests, Java Tools
> Affects Versions: 0.6
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: 0.7
>
> Attachments: findbugs.html
>
>
> FindBugs (http://findbugs.sourceforge.net/) is a program which uses static analysis to look for bugs in Java code
> Ideally we should incorporate Findbugs into our ant build such that we can be informed when new critical issues may have been introduced.
> In the interim findbugs can be run manually.
> Where critical issues are discovered by findbugs we should correct these
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2857) [Java] Running FindBugs against Java
codebase reveals room for improvement
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey updated QPID-2857:
------------------------------
Attachment: findbugs.html
Committed revision 996393.
Updated with a number of fixes to reduce the potential bugs which FindBugs highlighted
High Priority Warnings: 28
Medium Priority Warnings: 506
Total Warnings: 534
> [Java] Running FindBugs against Java codebase reveals room for improvement
> --------------------------------------------------------------------------
>
> Key: QPID-2857
> URL: https://issues.apache.org/jira/browse/QPID-2857
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Broker MessageStore - DerbyStore, Java Client, Java Clustering, Java Common, Java Management : CLI Tool, Java Management : JMX Console, Java Management : JMX Interface, Java Management : QMan, Java Management : QMF, Java Performance Tests, Java Tests, Java Tools
> Affects Versions: 0.6
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: 0.7
>
> Attachments: findbugs.html, findbugs.html
>
>
> FindBugs (http://findbugs.sourceforge.net/) is a program which uses static analysis to look for bugs in Java code
> Ideally we should incorporate Findbugs into our ant build such that we can be informed when new critical issues may have been introduced.
> In the interim findbugs can be run manually.
> Where critical issues are discovered by findbugs we should correct these
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2857) [Java] Running FindBugs against Java
codebase reveals room for improvement
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912257#action_12912257 ]
Robbie Gemmell commented on QPID-2857:
--------------------------------------
Committed revision 998700, removed around 60 high/medium warnings which FindBugs highlighted.
Current FindBugs stats:
High Priority Warnings: 0
Medium Priority Warnings: 383
Total Warnings: 383
> [Java] Running FindBugs against Java codebase reveals room for improvement
> --------------------------------------------------------------------------
>
> Key: QPID-2857
> URL: https://issues.apache.org/jira/browse/QPID-2857
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Broker MessageStore - DerbyStore, Java Client, Java Clustering, Java Common, Java Management : CLI Tool, Java Management : JMX Console, Java Management : JMX Interface, Java Management : QMan, Java Management : QMF, Java Performance Tests, Java Tests, Java Tools
> Affects Versions: 0.6
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: 0.7
>
> Attachments: findbugs.html, findbugs.html, report.html.zip
>
>
> FindBugs (http://findbugs.sourceforge.net/) is a program which uses static analysis to look for bugs in Java code
> Ideally we should incorporate Findbugs into our ant build such that we can be informed when new critical issues may have been introduced.
> In the interim findbugs can be run manually.
> Where critical issues are discovered by findbugs we should correct these
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2857) [Java] Running FindBugs against Java
codebase reveals room for improvement
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912258#action_12912258 ]
Robbie Gemmell commented on QPID-2857:
--------------------------------------
I also added/increased the Xmx setting for the FindBugs ant task added to the build system, as it would consistently OOM quickly when run otherwise. The FindBugs task catches this OOM itself and the ant build completes 'successfully' as a result. I viewed peak memory usage of around 350MB, so set Xmx to 512MB.
> [Java] Running FindBugs against Java codebase reveals room for improvement
> --------------------------------------------------------------------------
>
> Key: QPID-2857
> URL: https://issues.apache.org/jira/browse/QPID-2857
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Broker MessageStore - DerbyStore, Java Client, Java Clustering, Java Common, Java Management : CLI Tool, Java Management : JMX Console, Java Management : JMX Interface, Java Management : QMan, Java Management : QMF, Java Performance Tests, Java Tests, Java Tools
> Affects Versions: 0.6
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: 0.7
>
> Attachments: findbugs.html, findbugs.html, report.html.zip
>
>
> FindBugs (http://findbugs.sourceforge.net/) is a program which uses static analysis to look for bugs in Java code
> Ideally we should incorporate Findbugs into our ant build such that we can be informed when new critical issues may have been introduced.
> In the interim findbugs can be run manually.
> Where critical issues are discovered by findbugs we should correct these
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org