[GitHub] [cassandra] michaelsembwever commented on a change in pull request #858: CASSANDRA-16361 DROP COMPACT STORAGE should invalidate prepared statements still using CompactTableMetadata

[GitBox <gi...@apache.org>]

michaelsembwever commented on a change in pull request #858:
URL: https://github.com/apache/cassandra/pull/858#discussion_r545710782



##########
File path: src/java/org/apache/cassandra/schema/TableMetadata.java
##########
@@ -558,7 +558,8 @@ boolean changeAffectsPreparedStatements(TableMetadata updated)
             || !regularAndStaticColumns.equals(updated.regularAndStaticColumns)
             || !indexes.equals(updated.indexes)
             || params.defaultTimeToLive != updated.params.defaultTimeToLive
-            || params.gcGraceSeconds != updated.params.gcGraceSeconds;
+            || params.gcGraceSeconds != updated.params.gcGraceSeconds
+            || flags.contains(Flag.DENSE) && !updated.flags.contains(Flag.DENSE);

Review comment:
       can we also put it in parenthesis for readability…
   
   ```suggestion
               || ( !isCQLTable(flags) && isCQLTable(updated.flags) );
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org