You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2010/02/18 16:34:27 UTC

[jira] Created: (FELIX-2099) Cleanup logging

Cleanup logging
---------------

                 Key: FELIX-2099
                 URL: https://issues.apache.org/jira/browse/FELIX-2099
             Project: Felix
          Issue Type: Improvement
          Components: Web Console
    Affects Versions: webconsole-2.0.6
            Reporter: Felix Meschberger
             Fix For: webconsole-3.0.0


The WebConsole's internal BaseWebConsolePlugin class plugin provided a simple Logger facade to the LogService or stdout to its extensions. With the migration to using JQuery UI as per FELIX-1988 the BaseWebConsolePlugin will not be used any longer and thus the Logger is not available to the plugins.

For now, most logging goes to the GenericServlet.log() methods.

After FELIX-1988 is done, we should revisit logging:

* AbstractWebConsolePlugin should overwrite the GenericServlet.log() methods to use the simple Logger facade internally
* The Logger API might be provided as official API
* The Logger instance could be made available through the AbstractWebConsolePlugin (which already uses this internally)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2099) Cleanup logging

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835274#action_12835274 ] 

Valentin Valchev commented on FELIX-2099:
-----------------------------------------

IMHO it's simpler to use build-in Servlet API for logging.

BTW. I'm not quite sure that we need to override that. The HTTP Server implementation might also override that method and redirect the logs to the OSGi Log Service.

> Cleanup logging
> ---------------
>
>                 Key: FELIX-2099
>                 URL: https://issues.apache.org/jira/browse/FELIX-2099
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>    Affects Versions: webconsole-2.0.6
>            Reporter: Felix Meschberger
>             Fix For: webconsole-3.0.0
>
>
> The WebConsole's internal BaseWebConsolePlugin class plugin provided a simple Logger facade to the LogService or stdout to its extensions. With the migration to using JQuery UI as per FELIX-1988 the BaseWebConsolePlugin will not be used any longer and thus the Logger is not available to the plugins.
> For now, most logging goes to the GenericServlet.log() methods.
> After FELIX-1988 is done, we should revisit logging:
> * AbstractWebConsolePlugin should overwrite the GenericServlet.log() methods to use the simple Logger facade internally
> * The Logger API might be provided as official API
> * The Logger instance could be made available through the AbstractWebConsolePlugin (which already uses this internally)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FELIX-2099) Cleanup logging

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed FELIX-2099.
-----------------------------------


> Cleanup logging
> ---------------
>
>                 Key: FELIX-2099
>                 URL: https://issues.apache.org/jira/browse/FELIX-2099
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>    Affects Versions: webconsole-2.0.6
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: webconsole-3.0.0
>
>
> The WebConsole's internal BaseWebConsolePlugin class plugin provided a simple Logger facade to the LogService or stdout to its extensions. With the migration to using JQuery UI as per FELIX-1988 the BaseWebConsolePlugin will not be used any longer and thus the Logger is not available to the plugins.
> For now, most logging goes to the GenericServlet.log() methods.
> After FELIX-1988 is done, we should revisit logging:
> * AbstractWebConsolePlugin should overwrite the GenericServlet.log() methods to use the simple Logger facade internally
> * The Logger API might be provided as official API
> * The Logger instance could be made available through the AbstractWebConsolePlugin (which already uses this internally)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (FELIX-2099) Cleanup logging

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/FELIX-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12835388#action_12835388 ] 

Felix Meschberger commented on FELIX-2099:
------------------------------------------

Sounds reasonable, yes.

So we just have to make sure the Installer/Updater threads are able to log to the GenericServlet or ServletContext

> Cleanup logging
> ---------------
>
>                 Key: FELIX-2099
>                 URL: https://issues.apache.org/jira/browse/FELIX-2099
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>    Affects Versions: webconsole-2.0.6
>            Reporter: Felix Meschberger
>             Fix For: webconsole-3.0.0
>
>
> The WebConsole's internal BaseWebConsolePlugin class plugin provided a simple Logger facade to the LogService or stdout to its extensions. With the migration to using JQuery UI as per FELIX-1988 the BaseWebConsolePlugin will not be used any longer and thus the Logger is not available to the plugins.
> For now, most logging goes to the GenericServlet.log() methods.
> After FELIX-1988 is done, we should revisit logging:
> * AbstractWebConsolePlugin should overwrite the GenericServlet.log() methods to use the simple Logger facade internally
> * The Logger API might be provided as official API
> * The Logger instance could be made available through the AbstractWebConsolePlugin (which already uses this internally)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2099) Cleanup logging

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved FELIX-2099.
--------------------------------------

    Resolution: Fixed
      Assignee: Felix Meschberger

Cleanup of logging in Rev. 922540 :

All logging now goes through the GenericServlet.log methods where the AbstractWebConsolePlugin provides log methods taking a log level used to filter log messages on a log level configurable for all web console plugins.

Removed the now unused Logger and BaseManagementPlugin classes.

Simplified the BasedUpdateInstallHelper and its extension classes using a SimpleWebConsolePlugin as its basis for logging and service access.

Added configuration option (loglevel) to configure the loglevel message filter.

> Cleanup logging
> ---------------
>
>                 Key: FELIX-2099
>                 URL: https://issues.apache.org/jira/browse/FELIX-2099
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>    Affects Versions: webconsole-2.0.6
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: webconsole-3.0.0
>
>
> The WebConsole's internal BaseWebConsolePlugin class plugin provided a simple Logger facade to the LogService or stdout to its extensions. With the migration to using JQuery UI as per FELIX-1988 the BaseWebConsolePlugin will not be used any longer and thus the Logger is not available to the plugins.
> For now, most logging goes to the GenericServlet.log() methods.
> After FELIX-1988 is done, we should revisit logging:
> * AbstractWebConsolePlugin should overwrite the GenericServlet.log() methods to use the simple Logger facade internally
> * The Logger API might be provided as official API
> * The Logger instance could be made available through the AbstractWebConsolePlugin (which already uses this internally)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.