[GitHub] [cordova-android] erisu commented on issue #837: Add `.npmrc` and `.editorconfig`

[GitBox <gi...@apache.org>]

erisu commented on issue #837: Add `.npmrc` and `.editorconfig`
URL: https://github.com/apache/cordova-android/issues/837#issuecomment-538807753
 
 
   As @breautek  pointed out, this will require a lot of discussions to determine what would be applied to all Cordova repos and not just Android. We do not generally like to make one-offs if they can be avoided.
   
   Looking at some of these changes, they would not fit with our current workflow or coding style.
   
   Coding Syntax
   * `max_line_length` is not something we determined or enforced. 
   * `json` file indention is 2 not 4.
   * `md` files also trim trailing whitespaces
   * `xml` files indetion is 4 not 2.
   
   NPM
   * `save-exact` is `false`, not `true`
   * `save-prefix` is `default` not changed
   * `prefer-offline` As part of building a release package for the vote, it is required that I test everything as if it was a fresh package. It best of this setting left the default and not set.
   * `message` is not needed. We do not use `npm version`
   * `progress` is a user preference. when doing a release I am installing over 30 repos and like to make sure the progress didn't hang.
   * `update-notifier` user preference
   * `unicode` user preference.
   * `optional` user preference. Best to leave as default so each CI service could have the same scripts instead of managing one to install optional vs another.
   * `ignore-scripts` might not be needed.
   * `cache` not needed
   * `loglevel` I think should be `default` and also what @breautek pointed out.
   * `no-audit`, there is no problem with default.
   * `maxsockets` not needed.
   * `tag-version-prefix` again not needed as we do not use `npm version`
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org