You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/30 22:56:51 UTC

[GitHub] [arrow] alamb commented on a change in pull request #8762: ARROW-10717 [Rust] [DataFusion] Add support for right join

alamb commented on a change in pull request #8762:
URL: https://github.com/apache/arrow/pull/8762#discussion_r532955833



##########
File path: rust/datafusion/src/physical_plan/hash_join.rs
##########
@@ -260,18 +261,23 @@ fn build_batch_from_indices(
     // this is just for symmetry of the code below.
     let right = vec![right.clone()];
 
+    let (primary_is_left, primary, secondary) = match join_type {

Review comment:
       Maybe this could be called `outer_is_left`, `outer`, and `inner` to use standard terms rather than `primary` and `secondary`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org