You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/07 14:42:34 UTC

[GitHub] [arrow] andygrove opened a new pull request #9438: ARROW-11544: [Rust] [DataFusion] Implement as_any for AggregateExpr

andygrove opened a new pull request #9438:
URL: https://github.com/apache/arrow/pull/9438


   Implement as_any for AggregateExpr so it can be downcast to a known implementation. This is consistent with the downcasting support we already had for PhysicalExpr.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove commented on pull request #9438: ARROW-11544: [Rust] [DataFusion] Implement as_any for AggregateExpr

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #9438:
URL: https://github.com/apache/arrow/pull/9438#issuecomment-774685372


   @jorgecarleitao @alamb fyi


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] andygrove closed pull request #9438: ARROW-11544: [Rust] [DataFusion] Implement as_any for AggregateExpr

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #9438:
URL: https://github.com/apache/arrow/pull/9438


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #9438: ARROW-11544: [Rust] [DataFusion] Implement as_any for AggregateExpr

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9438:
URL: https://github.com/apache/arrow/pull/9438#issuecomment-774685380


   https://issues.apache.org/jira/browse/ARROW-11544


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] codecov-io commented on pull request #9438: ARROW-11544: [Rust] [DataFusion] Implement as_any for AggregateExpr

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9438:
URL: https://github.com/apache/arrow/pull/9438#issuecomment-774688466


   # [Codecov](https://codecov.io/gh/apache/arrow/pull/9438?src=pr&el=h1) Report
   > Merging [#9438](https://codecov.io/gh/apache/arrow/pull/9438?src=pr&el=desc) (1e3ebce) into [master](https://codecov.io/gh/apache/arrow/commit/39dfd626cdcafdf37c22d81f669be41d5e408ef1?el=desc) (39dfd62) will **decrease** coverage by `0.01%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9438/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9438?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9438      +/-   ##
   ==========================================
   - Coverage   82.11%   82.09%   -0.02%     
   ==========================================
     Files         232      232              
     Lines       54331    54345      +14     
   ==========================================
   + Hits        44613    44614       +1     
   - Misses       9718     9731      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9438?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...tafusion/src/physical\_plan/distinct\_expressions.rs](https://codecov.io/gh/apache/arrow/pull/9438/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Rpc3RpbmN0X2V4cHJlc3Npb25zLnJz) | `90.29% <0.00%> (-0.89%)` | :arrow_down: |
   | [...atafusion/src/physical\_plan/expressions/average.rs](https://codecov.io/gh/apache/arrow/pull/9438/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2F2ZXJhZ2UucnM=) | `82.30% <0.00%> (-1.49%)` | :arrow_down: |
   | [.../datafusion/src/physical\_plan/expressions/count.rs](https://codecov.io/gh/apache/arrow/pull/9438/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL2NvdW50LnJz) | `85.86% <0.00%> (-1.91%)` | :arrow_down: |
   | [...atafusion/src/physical\_plan/expressions/min\_max.rs](https://codecov.io/gh/apache/arrow/pull/9438/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL21pbl9tYXgucnM=) | `91.54% <0.00%> (-1.76%)` | :arrow_down: |
   | [...st/datafusion/src/physical\_plan/expressions/sum.rs](https://codecov.io/gh/apache/arrow/pull/9438/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zL3N1bS5ycw==) | `77.27% <0.00%> (-1.02%)` | :arrow_down: |
   | [rust/datafusion/src/physical\_plan/mod.rs](https://codecov.io/gh/apache/arrow/pull/9438/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL21vZC5ycw==) | `86.00% <ø> (ø)` | |
   | [rust/datafusion/src/physical\_plan/udaf.rs](https://codecov.io/gh/apache/arrow/pull/9438/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3VkYWYucnM=) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
   | [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9438/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.05% <0.00%> (+0.19%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9438?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9438?src=pr&el=footer). Last update [39dfd62...1e3ebce](https://codecov.io/gh/apache/arrow/pull/9438?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org