You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/03/18 18:09:46 UTC
[GitHub] [activemq-artemis] sebthom opened a new pull request #3499: NO-JIRA Remove unused private logger field
sebthom opened a new pull request #3499:
URL: https://github.com/apache/activemq-artemis/pull/3499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3499: NO-JIRA Remove unused private logger field
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3499:
URL: https://github.com/apache/activemq-artemis/pull/3499#discussion_r597162815
##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
##########
@@ -152,8 +151,6 @@
*/
private static final byte NEW_LINE = (byte) '\n';
- private static final Logger logger = Logger.getLogger(Base64.class);
Review comment:
@sebthom thanks for the fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3499: NO-JIRA Remove unused private logger field
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3499:
URL: https://github.com/apache/activemq-artemis/pull/3499#discussion_r597162532
##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
##########
@@ -152,8 +151,6 @@
*/
private static final byte NEW_LINE = (byte) '\n';
- private static final Logger logger = Logger.getLogger(Base64.class);
Review comment:
I wish Java was like Go.. something private like this without being used should been a compilation error.
Sure, you can use errorProne.. etc... but not as clear!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic merged pull request #3499: NO-JIRA Remove unused private logger field
Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3499:
URL: https://github.com/apache/activemq-artemis/pull/3499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3499: NO-JIRA Remove unused private logger field
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on a change in pull request #3499:
URL: https://github.com/apache/activemq-artemis/pull/3499#discussion_r597162815
##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java
##########
@@ -152,8 +151,6 @@
*/
private static final byte NEW_LINE = (byte) '\n';
- private static final Logger logger = Logger.getLogger(Base64.class);
Review comment:
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org