You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by André Malo <nd...@perlig.de> on 2004/04/24 13:41:48 UTC
APR 0.9: apr_temp_dir_get broken
The test file is missing a placeholder pattern. That made the use of
htpasswd impossible. The following is just a backport from 1.0:
Index: tempdir.c
===================================================================
RCS file: /home/cvspublic/apr/file_io/unix/tempdir.c,v
retrieving revision 1.2.2.1
diff -u -r1.2.2.1 tempdir.c
--- tempdir.c 13 Feb 2004 09:33:43 -0000 1.2.2.1
+++ tempdir.c 24 Apr 2004 11:39:57 -0000
@@ -30,7 +30,7 @@
static int test_tempdir(const char *temp_dir, apr_pool_t *p)
{
apr_file_t *dummy_file;
- const char *path = apr_pstrcat(p, temp_dir, "/apr-tmp", NULL);
+ const char *path = apr_pstrcat(p, temp_dir, "/apr-tmp.XXXXXX", NULL);
if (apr_file_mktemp(&dummy_file, (char *)path, 0, p) == APR_SUCCESS) {
if (apr_file_putc('!', dummy_file) == APR_SUCCESS) {
nd
--
Das, was ich nicht kenne, spielt stückzahlmäßig *keine* Rolle.
-- Helmut Schellong in dclc
Re: APR 0.9: apr_temp_dir_get broken
Posted by Jeff Trawick <tr...@attglobal.net>.
André Malo wrote:
> *shrug* I'd commit it myself, but I don't have sufficient karma.
committed
Re: APR 0.9: apr_temp_dir_get broken
Posted by André Malo <nd...@perlig.de>.
* Thom May <th...@planetarytramp.net> wrote:
> * Andr? Malo (nd@perlig.de) wrote :
> > * Thom May <th...@planetarytramp.net> wrote:
> >
> > > * Andr? Malo (nd@perlig.de) wrote :
> > > >
> > > > The test file is missing a placeholder pattern. That made the use of
> > > > htpasswd impossible. The following is just a backport from 1.0:
> > > >
> > > yeah. +1.
> > > (mutters about glibc being stricter than bsd's libc on this one).
> >
> > cool. Would be nice if someone could commit it ;-)
> >
> gar. don't ask for much, do you? :-)
*shrug* I'd commit it myself, but I don't have sufficient karma.
nd
Re: APR 0.9: apr_temp_dir_get broken
Posted by Thom May <th...@planetarytramp.net>.
* Andr? Malo (nd@perlig.de) wrote :
> * Thom May <th...@planetarytramp.net> wrote:
>
> > * Andr? Malo (nd@perlig.de) wrote :
> > >
> > > The test file is missing a placeholder pattern. That made the use of
> > > htpasswd impossible. The following is just a backport from 1.0:
> > >
> > yeah. +1.
> > (mutters about glibc being stricter than bsd's libc on this one).
>
> cool. Would be nice if someone could commit it ;-)
>
gar. don't ask for much, do you? :-)
-Thom
Re: APR 0.9: apr_temp_dir_get broken
Posted by André Malo <nd...@perlig.de>.
* Thom May <th...@planetarytramp.net> wrote:
> * Andr? Malo (nd@perlig.de) wrote :
> >
> > The test file is missing a placeholder pattern. That made the use of
> > htpasswd impossible. The following is just a backport from 1.0:
> >
> yeah. +1.
> (mutters about glibc being stricter than bsd's libc on this one).
cool. Would be nice if someone could commit it ;-)
nd
--
Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook.
Ook! Ook? Ook. Ook? Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook. Ook.
Ook. Ook. Ook. Ook. Ook? Ook. Ook! Ook! Ook? Ook! Ook. Ook? Ook. Ook.
Ook. Ook. Ook. Ook. Ook! Ook. Ook! Ook! Ook! Ook! Ook! Ook.
Re: APR 0.9: apr_temp_dir_get broken
Posted by Thom May <th...@planetarytramp.net>.
* Andr? Malo (nd@perlig.de) wrote :
>
> The test file is missing a placeholder pattern. That made the use of
> htpasswd impossible. The following is just a backport from 1.0:
>
yeah. +1.
(mutters about glibc being stricter than bsd's libc on this one).
-Thom
> Index: tempdir.c
> ===================================================================
> RCS file: /home/cvspublic/apr/file_io/unix/tempdir.c,v
> retrieving revision 1.2.2.1
> diff -u -r1.2.2.1 tempdir.c
> --- tempdir.c 13 Feb 2004 09:33:43 -0000 1.2.2.1
> +++ tempdir.c 24 Apr 2004 11:39:57 -0000
> @@ -30,7 +30,7 @@
> static int test_tempdir(const char *temp_dir, apr_pool_t *p)
> {
> apr_file_t *dummy_file;
> - const char *path = apr_pstrcat(p, temp_dir, "/apr-tmp", NULL);
> + const char *path = apr_pstrcat(p, temp_dir, "/apr-tmp.XXXXXX", NULL);
>
> if (apr_file_mktemp(&dummy_file, (char *)path, 0, p) == APR_SUCCESS) {
> if (apr_file_putc('!', dummy_file) == APR_SUCCESS) {
>
> nd