You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "maksaska (via GitHub)" <gi...@apache.org> on 2026/06/09 15:50:35 UTC

[PR] IGNITE-28759 Updated latest ignite dependency version to 2.18 [ignite]

maksaska opened a new pull request, #13226:
URL: https://github.com/apache/ignite/pull/13226

   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [ ] There is a single JIRA ticket related to the pull request. 
   - [ ] The web-link to the pull request is attached to the JIRA ticket.
   - [ ] The JIRA ticket has the _Patch Available_ state.
   - [ ] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [ ] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [ ] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28759 [ducktests] Bump ducktape to 0.15 and Ignite to 2.18 [ignite]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13226:
URL: https://github.com/apache/ignite/pull/13226#discussion_r3958033403


##########
modules/ducktests/tests/ignitetest/utils/ignite_test.py:
##########
@@ -32,7 +32,7 @@
 
 class IgniteTestContext(TestContext):
     def __init__(self, test_context):
-        super().__init__()
+        super().__init__(**test_context.__dict__)
         self.__dict__.update(**test_context.__dict__)

Review Comment:
   `super().__init__(**test_context.__dict__)` will raise `TypeError` if `test_context.__dict__` contains keys that `TestContext.__init__` doesn’t accept. Consider either (a) reverting to `super().__init__()` and only copying attributes, or (b) filtering the kwargs to only parameters accepted by `TestContext.__init__` before splatting. Also, the subsequent `self.__dict__.update(...)` can overwrite values initialized by `TestContext` (including any normalization it performs), so it should be removed or changed to only set missing attributes.



##########
modules/ducktests/tests/docker/run_tests.sh:
##########
@@ -138,7 +149,7 @@ done
 
 if [ -z "$IMAGE_NAME" ]; then
     IMAGE_NAME="$IMAGE_PREFIX-$JDK_VERSION"

Review Comment:
   The image tag default (`$IMAGE_PREFIX-$JDK_VERSION`) does not incorporate `PYTHON_VERSION`, but the build output differs based on `-p`. If a user builds with different Python versions, they’ll overwrite/reuse the same tag, which can lead to running tests on an unexpected Python runtime. Include Python (and ideally also the no-cache choice doesn’t matter) in the default image name (e.g., suffix with `-py$PYTHON_VERSION`) or otherwise ensure unique tagging per Python version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28759 [ducktests] Bump ducktape to 0.15 and Ignite to 2.18 [ignite]

Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #13226:
URL: https://github.com/apache/ignite/pull/13226#discussion_r3959830754


##########
modules/ducktests/tests/ignitetest/utils/ignite_test.py:
##########
@@ -32,7 +32,7 @@
 
 class IgniteTestContext(TestContext):
     def __init__(self, test_context):
-        super().__init__()
+        super().__init__(**test_context.__dict__)
         self.__dict__.update(**test_context.__dict__)

Review Comment:
   Thanks - checked both halves against the ducktape 0.15.0 source we're pinning
   
     1) TypeError / filtering the kwargs
   
     TestContext.__init__ is `def __init__(self, **kwargs)` and reads every field via
     `kwargs.get(...)`, so unknown keys are silently ignored and a TypeError isn't
     reachable — a filter would be dead code. The splat is also ducktape's own idiom:
     TestContext.copy() does `TestContext(**self.__dict__)` followed by
     `ctx_copy.__dict__.update(**kwargs)`.
   
     For context on why the line changed at all: 0.15 turned
     `kwargs.get("session_context")` into `kwargs["session_context"]` and then
     dereferences it (`self.session_context.enable_jvm_logs` for ServiceRegistry).
     So the previous `super().__init__()` now raises KeyError: 'session_context', not
     TypeError — that's what our checks caught on the 0.15 bump
     (checks/utils/check_cluster.py drives @cluster -> ParametrizableClusterMetadata.apply
     -> IgniteTestContext.resolve). Reverting to option (a) re-breaks it, so I've left
     the splat as is.
   
     2) The subsequent self.__dict__.update(...) — agreed, fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28759 [ducktests] Bump ducktape to 0.15 and Ignite to 2.18 [ignite]

Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan merged PR #13226:
URL: https://github.com/apache/ignite/pull/13226


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28759 [ducktests] Bump ducktape to 0.15 and Ignite to 2.18 [ignite]

Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #13226:
URL: https://github.com/apache/ignite/pull/13226#discussion_r3966596500


##########
modules/ducktests/tests/docker/ducker-ignite:
##########
@@ -288,14 +301,16 @@ ducker_build() {
         case "${1}" in
             -j|--jdk) set_once jdk_version "${2}" "the OpenJDK base image"; shift 2;;
             -p|--python) set_once python_version "${2}" "the Python version"; shift 2;;
+            --no-cache) set_once no_cache "true"; shift;;
             -c|--context) docker_context="${2}"; shift 2;;

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28759 [ducktests] Bump ducktape to 0.15 and Ignite to 2.18 [ignite]

Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #13226:
URL: https://github.com/apache/ignite/pull/13226#discussion_r3959791079


##########
modules/ducktests/tests/docker/run_tests.sh:
##########
@@ -138,7 +149,7 @@ done
 
 if [ -z "$IMAGE_NAME" ]; then
     IMAGE_NAME="$IMAGE_PREFIX-$JDK_VERSION"

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28759 [ducktests] Bump ducktape to 0.15 and Ignite to 2.18 [ignite]

Posted by "maksaska (via GitHub)" <gi...@apache.org>.
maksaska commented on code in PR #13226:
URL: https://github.com/apache/ignite/pull/13226#discussion_r3966591983


##########
modules/ducktests/tests/docker/ducker-ignite:
##########
@@ -63,15 +66,19 @@ Usage: ${script_path} [command] [options]
 help|-h|--help
     Display this help message
 
-build [-j|--jdk JDK] [-p|--python PYTHON_VERSION] [-c|--context] [image-name]
+build [-j|--jdk JDK] [-p|--python PYTHON_VERSION] [--no-cache] [-c|--context] [image-name]
     Build a docker image that represents ducker node. Image is tagged with specified ${image_name}.
+    If the image name is omitted, it defaults to ${default_image_name}-<jdk>-py<python-version>,
+    so that images built with different JDK or Python versions do not overwrite each other.

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] IGNITE-28759 [ducktests] Bump ducktape to 0.15 and Ignite to 2.18 [ignite]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13226:
URL: https://github.com/apache/ignite/pull/13226#discussion_r3964879003


##########
modules/ducktests/tests/docker/ducker-ignite:
##########
@@ -63,15 +66,19 @@ Usage: ${script_path} [command] [options]
 help|-h|--help
     Display this help message
 
-build [-j|--jdk JDK] [-p|--python PYTHON_VERSION] [-c|--context] [image-name]
+build [-j|--jdk JDK] [-p|--python PYTHON_VERSION] [--no-cache] [-c|--context] [image-name]
     Build a docker image that represents ducker node. Image is tagged with specified ${image_name}.
+    If the image name is omitted, it defaults to ${default_image_name}-<jdk>-py<python-version>,
+    so that images built with different JDK or Python versions do not overwrite each other.

Review Comment:
   The help text references `${image_name}`, but that variable isn’t set when printing `usage()`, so the output will be empty/misleading (e.g., "tagged with specified "). Use plain wording (or a placeholder like `<image-name>`) instead of expanding an undefined variable.



##########
modules/ducktests/tests/docker/ducker-ignite:
##########
@@ -288,14 +301,16 @@ ducker_build() {
         case "${1}" in
             -j|--jdk) set_once jdk_version "${2}" "the OpenJDK base image"; shift 2;;
             -p|--python) set_once python_version "${2}" "the Python version"; shift 2;;
+            --no-cache) set_once no_cache "true"; shift;;
             -c|--context) docker_context="${2}"; shift 2;;

Review Comment:
   `set_once` expects a human-readable description as its 3rd argument for error messages; the `--no-cache` case omits it. If the flag is provided more than once, the script will error with an unhelpful message ("more than one value specified for "). Pass a description string for consistency with other options.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org