[GitHub] [pulsar] Technoboy- commented on a diff in pull request #15281: [improve][broker] Make some methods of `BrokersBase` pure async.

[GitBox <gi...@apache.org>]

Technoboy- commented on code in PR #15281:
URL: https://github.com/apache/pulsar/pull/15281#discussion_r857505656


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java:
##########
@@ -237,9 +236,16 @@ public List<String> getDynamicConfigurationName() {
     @Path("/configuration/runtime")
     @ApiOperation(value = "Get all runtime configurations. This operation requires Pulsar super-user privileges.")
     @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission") })
-    public Map<String, String> getRuntimeConfiguration() {
-        validateSuperUserAccess();
-        return pulsar().getBrokerService().getRuntimeConfiguration();
+    public void getRuntimeConfiguration(@Suspended AsyncResponse asyncResponse) {
+        validateSuperUserAccessAsync()
+                .thenAccept(__ -> {
+                    LOG.info("[{}] Successfully to get runtime configuration.", clientAppId());

Review Comment:
   I'm wondering if we need this successful log.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org