You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Bryan Ellis <er...@apache.org> on 2019/10/28 10:13:03 UTC
[VOTE] Cordova-Common 3.2.1 Release
Please review and vote on this Cordova Common Patch Release v3.2.1
by replying to this email (and keep discussion on the DISCUSS thread)
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/common-v3.2.1
The package was published from its corresponding git tag:
cordova-common: 3.2.1 (61e4099d5a)
Upon a successful vote I will upload the archive to dist/, publish it to
npm, and post the blog post.
Voting guidelines:
https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
Voting will go on for a minimum of 48 hours.
I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all dependencies and subdependencies
have Apache-compatible licenses
* Ensured continuous build was green when repo was tagged
* NPM Audit
* NPM Test
Re: [VOTE] Cordova-Common 3.2.1 Release
Posted by Bryan Ellis <er...@apache.org>.
The vote has now closed. The results are:
Positive Binding Votes: 3
* Bryan Ellis
* Raphael von der Grün
* Ken Naito
Negative Binding Votes: 0
The vote has passed.
Thanks everyone!
On Mon, Oct 28, 2019 at 7:13 PM Bryan Ellis <er...@apache.org> wrote:
> Please review and vote on this Cordova Common Patch Release v3.2.1
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/common-v3.2.1
>
> The package was published from its corresponding git tag:
> cordova-common: 3.2.1 (61e4099d5a)
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Test
>
Re: [VOTE] Cordova-Common 3.2.1 Release
Posted by Ken Naito <ke...@monaca.io>.
+1
* coho verify-archive OK
* coho verify-tags OK
* The commit
https://github.com/apache/cordova-common/commit/bd32d6c12b43e4e93b33cf4c39121cac5000e1d8
is green
On 2019/10/28 19:13, Bryan Ellis wrote:
> Please review and vote on this Cordova Common Patch Release v3.2.1
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/common-v3.2.1
>
> The package was published from its corresponding git tag:
> cordova-common: 3.2.1 (61e4099d5a)
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Test
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [VOTE] Cordova-Common 3.2.1 Release
Posted by Bryan Ellis <er...@apache.org>.
**Bump**
If anyone has time, can you please take a look and vote on this
cordova-common release patch?
The main purpose of this patch release is to revert a PR that causes
`plugin install` to not set permissions to the `AndroidManifest.xml` when
`config.xml` and `plugin.xml` defines the same element block type
(`config-file` and/or `edit-config`).
For any further discussion, please post in the discussion thread.
Thank you
On Mon, Oct 28, 2019 at 10:54 PM <ra...@gmail.com> wrote:
> I vote +1
>
> - CI is green
> - I reviewed the diff from 3.2.0..3.2.1
>
> Am Mo., 28. Okt. 2019 um 11:13 Uhr schrieb Bryan Ellis <er...@apache.org>:
>
> > Please review and vote on this Cordova Common Patch Release v3.2.1
> > by replying to this email (and keep discussion on the DISCUSS thread)
> >
> > The archive has been published to dist/dev:
> > https://dist.apache.org/repos/dist/dev/cordova/common-v3.2.1
> >
> > The package was published from its corresponding git tag:
> > cordova-common: 3.2.1 (61e4099d5a)
> >
> > Upon a successful vote I will upload the archive to dist/, publish it to
> > npm, and post the blog post.
> >
> > Voting guidelines:
> >
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repo was tagged
> > * NPM Audit
> > * NPM Test
> >
>
Re: [VOTE] Cordova-Common 3.2.1 Release
Posted by ra...@gmail.com.
I vote +1
- CI is green
- I reviewed the diff from 3.2.0..3.2.1
Am Mo., 28. Okt. 2019 um 11:13 Uhr schrieb Bryan Ellis <er...@apache.org>:
> Please review and vote on this Cordova Common Patch Release v3.2.1
> by replying to this email (and keep discussion on the DISCUSS thread)
>
> The archive has been published to dist/dev:
> https://dist.apache.org/repos/dist/dev/cordova/common-v3.2.1
>
> The package was published from its corresponding git tag:
> cordova-common: 3.2.1 (61e4099d5a)
>
> Upon a successful vote I will upload the archive to dist/, publish it to
> npm, and post the blog post.
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all dependencies and subdependencies
> have Apache-compatible licenses
> * Ensured continuous build was green when repo was tagged
> * NPM Audit
> * NPM Test
>