You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by Dongjoon Hyun <do...@apache.org> on 2015/10/14 21:53:37 UTC
Fixing or Removing DriverSubmissionSettings
Hi, All.
I found a default parameter bug in DriverSubmissionSettings.cs.
{code}
// deault to 512MB if no value is provided
private int _driverMemory = 0;
{code}
But it seems to be unused any more in REEF after removing
ClrClientHelper.cs by https://issues.apache.org/jira/browse/REEF-752.
It's a public class, should we add obsoletes tag to remove this?
Or, can I delete this safely now?
Thanks,
Dongjoon
Re: Fixing or Removing DriverSubmissionSettings
Posted by Dongjoon Hyun <do...@apache.org>.
Thank you. Then, I will make that class obsolete.
Dongjoon.
On Thursday, 15 October 2015, Markus Weimer <ma...@weimo.de> wrote:
> If the class is `public` but unused, we might still have to mark it as
> obsolete for one iteration :-(
>
> Markus
>
> On Wed, Oct 14, 2015 at 10:06 PM, Dongjoon Hyun <dongjoon@apache.org
> <javascript:;>> wrote:
> > I mean DriverSubmissionSettings class is `public`.
> > And also I'm asking if it is possible to remove
> DriverSubmissionSettings.cs.
> > Sorry for the ambiguity.
> >
> > Dongjoon.
> >
> > On Thu, Oct 15, 2015 at 4:53 AM, Dongjoon Hyun <dongjoon@apache.org
> <javascript:;>> wrote:
> >
> >> Hi, All.
> >>
> >> I found a default parameter bug in DriverSubmissionSettings.cs.
> >>
> >> {code}
> >> // deault to 512MB if no value is provided
> >> private int _driverMemory = 0;
> >> {code}
> >>
> >> But it seems to be unused any more in REEF after removing
> >> ClrClientHelper.cs by https://issues.apache.org/jira/browse/REEF-752.
> >>
> >> It's a public class, should we add obsoletes tag to remove this?
> >> Or, can I delete this safely now?
> >>
> >> Thanks,
> >> Dongjoon
> >>
>
Re: Fixing or Removing DriverSubmissionSettings
Posted by Markus Weimer <ma...@weimo.de>.
If the class is `public` but unused, we might still have to mark it as
obsolete for one iteration :-(
Markus
On Wed, Oct 14, 2015 at 10:06 PM, Dongjoon Hyun <do...@apache.org> wrote:
> I mean DriverSubmissionSettings class is `public`.
> And also I'm asking if it is possible to remove DriverSubmissionSettings.cs.
> Sorry for the ambiguity.
>
> Dongjoon.
>
> On Thu, Oct 15, 2015 at 4:53 AM, Dongjoon Hyun <do...@apache.org> wrote:
>
>> Hi, All.
>>
>> I found a default parameter bug in DriverSubmissionSettings.cs.
>>
>> {code}
>> // deault to 512MB if no value is provided
>> private int _driverMemory = 0;
>> {code}
>>
>> But it seems to be unused any more in REEF after removing
>> ClrClientHelper.cs by https://issues.apache.org/jira/browse/REEF-752.
>>
>> It's a public class, should we add obsoletes tag to remove this?
>> Or, can I delete this safely now?
>>
>> Thanks,
>> Dongjoon
>>
Re: Fixing or Removing DriverSubmissionSettings
Posted by Dongjoon Hyun <do...@apache.org>.
I mean DriverSubmissionSettings class is `public`.
And also I'm asking if it is possible to remove DriverSubmissionSettings.cs.
Sorry for the ambiguity.
Dongjoon.
On Thu, Oct 15, 2015 at 4:53 AM, Dongjoon Hyun <do...@apache.org> wrote:
> Hi, All.
>
> I found a default parameter bug in DriverSubmissionSettings.cs.
>
> {code}
> // deault to 512MB if no value is provided
> private int _driverMemory = 0;
> {code}
>
> But it seems to be unused any more in REEF after removing
> ClrClientHelper.cs by https://issues.apache.org/jira/browse/REEF-752.
>
> It's a public class, should we add obsoletes tag to remove this?
> Or, can I delete this safely now?
>
> Thanks,
> Dongjoon
>