You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Arnaud HERITIER <ah...@gmail.com> on 2007/11/30 02:12:38 UTC

Re: [m1] PMD plugin dependencies

Hi jeff,

  What you have to check, it is if jaxen is loaded by the core. If that's
the case, the version in the core is always used.
  If not, it is the version of jaxen used by the first plugin loaded which
use it.
  That's why we tried for the 1.1 release of maven to align dependencies to
have less side effects.
  I hope that 1.1.1 is compatible with 1.1-beta-9. Depending of the part of
jaxen which is used by pmd it's possible that it works fine with the old
version.
  If it's not the case you'll have to try to upgrade jaxen everywhere...

Arnaud

On Nov 30, 2007 2:05 AM, Jeff Jensen <je...@upstairstechnology.com>
wrote:

> Hi Arnaud,
> PMD 4.1 has updated its deps (e.g. asm and jaxen), and I am concerned on
> upgrading the plugin.  I know you (and possibly others) spent considerable
> time aligning the dependencies amongst core and many other plugins.  I
> know
> Jaxen was one of them.
>
> Do you have concerns/suggestions on updating the plugin deps in this
> manner
> (e.g. jaxen from 1.1-beta-9 to 1.1.1)?
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

RE: [m1] PMD plugin dependencies

Posted by Jeff Jensen <je...@upstairstechnology.com>.
Ugh!!  :-(

Thanks for the help Arnaud, Xavier, and Lukas...


> -----Original Message-----
> From: Arnaud HERITIER [mailto:aheritier@gmail.com]
> Sent: Saturday, December 01, 2007 4:33 PM
> To: Maven Developers List
> Subject: Re: [m1] PMD plugin dependencies
> 
> Hi Xavier,
> 
>   Thanks a lot for your feedback !
>   Jeff, you know what to do if you want to use the new version of pmd in
> maven 1 land.
> 
> Arnaud
> 
> On Nov 30, 2007 7:49 PM, Xavier Le Vourch <xa...@brittanysoftware.com>
> wrote:
> 
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Hi,
> >
> >
> > Arnaud HERITIER wrote:
> > >   I hope that 1.1.1 is compatible with 1.1-beta-9. Depending of the
part
> > of
> > > jaxen which is used by pmd it's possible that it works fine with the
old
> > > version.
> >
> >
> > First, let me give you some general info: I'm an admin for the pmd
> > project and I just released pmd 4.1 and submitted the upload request for
> > it.
> >
> > I've also submitted a few patches for the pmd plugin update as well
> > yesterday and earlier today.
> >
> > Now that you know where I'm coming from, pmd 4.1 does require jaxen
> > 1.1.1 to work correctly as it includes a critical bug fix.
> >
> > Without it, at least one rule (AddEmptyString in optimizations.xml) will
> > fail. The regression tests for the rule fail when jaxen 1.1 is used.
> >
> > The expression checked by that rule is pretty common so if the rule is
> > included, most likely pmd will fail parsing regular code.
> >
> >
> > Sorry for the bad news...
> >
> >
> > Xavier
> >
> > - --
> > Xavier Le Vourch
> > Brittany Software, Inc.
> > <xa...@brittanysoftware.com>
> >
> > PGP Key (ID 0x896C5947): http://brittanysoftware.com/gpg_key.asc
> > Key fingerprint: 73B3 6370 B8C5 4325 F2D8  4115 0372 5805 896C 5947
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.5 (GNU/Linux)
> > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> >
> > iD8DBQFHUFtWA3JYBYlsWUcRApPxAJ4+h0CTItxNFPpcYVelVm73yKtCZwCeNzrr
> > zzhReGde2FM/31OHEuU1IfE=
> > =0NAY
> > -----END PGP SIGNATURE-----
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
> 
> 
> --
> ..........................................................
> Arnaud HERITIER
> ..........................................................
> OCTO Technology - aheritier AT octo DOT com
> www.octo.com | blog.octo.com
> ..........................................................
> ASF - aheritier AT apache DOT org
> www.apache.org | maven.apache.org
> ...........................................................



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [m1] PMD plugin dependencies

Posted by Arnaud HERITIER <ah...@gmail.com>.
Hi Xavier,

  Thanks a lot for your feedback !
  Jeff, you know what to do if you want to use the new version of pmd in
maven 1 land.

Arnaud

On Nov 30, 2007 7:49 PM, Xavier Le Vourch <xa...@brittanysoftware.com>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
>
> Arnaud HERITIER wrote:
> >   I hope that 1.1.1 is compatible with 1.1-beta-9. Depending of the part
> of
> > jaxen which is used by pmd it's possible that it works fine with the old
> > version.
>
>
> First, let me give you some general info: I'm an admin for the pmd
> project and I just released pmd 4.1 and submitted the upload request for
> it.
>
> I've also submitted a few patches for the pmd plugin update as well
> yesterday and earlier today.
>
> Now that you know where I'm coming from, pmd 4.1 does require jaxen
> 1.1.1 to work correctly as it includes a critical bug fix.
>
> Without it, at least one rule (AddEmptyString in optimizations.xml) will
> fail. The regression tests for the rule fail when jaxen 1.1 is used.
>
> The expression checked by that rule is pretty common so if the rule is
> included, most likely pmd will fail parsing regular code.
>
>
> Sorry for the bad news...
>
>
> Xavier
>
> - --
> Xavier Le Vourch
> Brittany Software, Inc.
> <xa...@brittanysoftware.com>
>
> PGP Key (ID 0x896C5947): http://brittanysoftware.com/gpg_key.asc
> Key fingerprint: 73B3 6370 B8C5 4325 F2D8  4115 0372 5805 896C 5947
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFHUFtWA3JYBYlsWUcRApPxAJ4+h0CTItxNFPpcYVelVm73yKtCZwCeNzrr
> zzhReGde2FM/31OHEuU1IfE=
> =0NAY
> -----END PGP SIGNATURE-----
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

Re: [m1] PMD plugin dependencies

Posted by Xavier Le Vourch <xa...@brittanysoftware.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,


Arnaud HERITIER wrote:
>   I hope that 1.1.1 is compatible with 1.1-beta-9. Depending of the part of
> jaxen which is used by pmd it's possible that it works fine with the old
> version.


First, let me give you some general info: I'm an admin for the pmd
project and I just released pmd 4.1 and submitted the upload request for it.

I've also submitted a few patches for the pmd plugin update as well
yesterday and earlier today.

Now that you know where I'm coming from, pmd 4.1 does require jaxen
1.1.1 to work correctly as it includes a critical bug fix.

Without it, at least one rule (AddEmptyString in optimizations.xml) will
fail. The regression tests for the rule fail when jaxen 1.1 is used.

The expression checked by that rule is pretty common so if the rule is
included, most likely pmd will fail parsing regular code.


Sorry for the bad news...


Xavier

- --
Xavier Le Vourch
Brittany Software, Inc.
<xa...@brittanysoftware.com>

PGP Key (ID 0x896C5947): http://brittanysoftware.com/gpg_key.asc
Key fingerprint: 73B3 6370 B8C5 4325 F2D8  4115 0372 5805 896C 5947
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHUFtWA3JYBYlsWUcRApPxAJ4+h0CTItxNFPpcYVelVm73yKtCZwCeNzrr
zzhReGde2FM/31OHEuU1IfE=
=0NAY
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: [m1] PMD plugin dependencies

Posted by Jeff Jensen <jj...@apache.org>.
I'm open to it.  I can complete the plugin upg and test with the existing
dep versions as well.  If it fails, then we are dead-ended without doing
those upgrades; if it does not fail, then we have options ;-)


> -----Original Message-----
> From: Arnaud HERITIER [mailto:aheritier@gmail.com]
> Sent: Friday, November 30, 2007 1:34 AM
> To: Maven Developers List
> Subject: Re: [m1] PMD plugin dependencies
> 
> yes if you want. we can produce minor updates by upgrading some
dependencies
> if it helps to improve plugins.
> 
> Arnaud
> 
> On Nov 30, 2007 7:52 AM, Lukas Theussl <lt...@apache.org> wrote:
> 
> > Bad news: jaxen is used in the core [1]
> > Good news: Arnaud had already upgraded a lot of deps and attached
> > patches (MAVEN-1797 - 1805), among them for jaxen [2]
> >
> > Should we work on m1.1.1 with only upgraded deps?
> >
> > :)
> > -Lukas
> >
> > [1] http://maven.apache.org/maven-1.x/dependencies.html
> > [2] http://jira.codehaus.org/browse/MAVEN-1797
> >
> >
> > Arnaud HERITIER wrote:
> > > Hi jeff,
> > >
> > >   What you have to check, it is if jaxen is loaded by the core. If
> > that's
> > > the case, the version in the core is always used.
> > >   If not, it is the version of jaxen used by the first plugin loaded
> > which
> > > use it.
> > >   That's why we tried for the 1.1 release of maven to align
dependencies
> > to
> > > have less side effects.
> > >   I hope that 1.1.1 is compatible with 1.1-beta-9. Depending of the
part
> > of
> > > jaxen which is used by pmd it's possible that it works fine with the
old
> > > version.
> > >   If it's not the case you'll have to try to upgrade jaxen
everywhere...
> > >
> > > Arnaud
> > >
> > > On Nov 30, 2007 2:05 AM, Jeff Jensen
<je...@upstairstechnology.com>
> > > wrote:
> > >
> > >
> > >>Hi Arnaud,
> > >>PMD 4.1 has updated its deps (e.g. asm and jaxen), and I am concerned
on
> > >>upgrading the plugin.  I know you (and possibly others) spent
> > considerable
> > >>time aligning the dependencies amongst core and many other plugins.  I
> > >>know
> > >>Jaxen was one of them.
> > >>
> > >>Do you have concerns/suggestions on updating the plugin deps in this
> > >>manner
> > >>(e.g. jaxen from 1.1-beta-9 to 1.1.1)?
> > >>
> > >>
> > >>
> > >>
> > >>---------------------------------------------------------------------
> > >>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>For additional commands, e-mail: dev-help@maven.apache.org
> > >>
> > >>
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
> 
> 
> --
> ..........................................................
> Arnaud HERITIER
> ..........................................................
> OCTO Technology - aheritier AT octo DOT com
> www.octo.com | blog.octo.com
> ..........................................................
> ASF - aheritier AT apache DOT org
> www.apache.org | maven.apache.org
> ...........................................................



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: [m1] PMD plugin dependencies

Posted by Jeff Jensen <je...@upstairstechnology.com>.
I'm open to it.  I can complete the plugin upg and test with the existing
dep versions as well.  If it fails, then we are dead-ended without doing
those upgrades; if it does not fail, then we have options ;-)


> -----Original Message-----
> From: Arnaud HERITIER [mailto:aheritier@gmail.com]
> Sent: Friday, November 30, 2007 1:34 AM
> To: Maven Developers List
> Subject: Re: [m1] PMD plugin dependencies
> 
> yes if you want. we can produce minor updates by upgrading some
dependencies
> if it helps to improve plugins.
> 
> Arnaud
> 
> On Nov 30, 2007 7:52 AM, Lukas Theussl <lt...@apache.org> wrote:
> 
> > Bad news: jaxen is used in the core [1]
> > Good news: Arnaud had already upgraded a lot of deps and attached
> > patches (MAVEN-1797 - 1805), among them for jaxen [2]
> >
> > Should we work on m1.1.1 with only upgraded deps?
> >
> > :)
> > -Lukas
> >
> > [1] http://maven.apache.org/maven-1.x/dependencies.html
> > [2] http://jira.codehaus.org/browse/MAVEN-1797
> >
> >
> > Arnaud HERITIER wrote:
> > > Hi jeff,
> > >
> > >   What you have to check, it is if jaxen is loaded by the core. If
> > that's
> > > the case, the version in the core is always used.
> > >   If not, it is the version of jaxen used by the first plugin loaded
> > which
> > > use it.
> > >   That's why we tried for the 1.1 release of maven to align
dependencies
> > to
> > > have less side effects.
> > >   I hope that 1.1.1 is compatible with 1.1-beta-9. Depending of the
part
> > of
> > > jaxen which is used by pmd it's possible that it works fine with the
old
> > > version.
> > >   If it's not the case you'll have to try to upgrade jaxen
everywhere...
> > >
> > > Arnaud
> > >
> > > On Nov 30, 2007 2:05 AM, Jeff Jensen
<je...@upstairstechnology.com>
> > > wrote:
> > >
> > >
> > >>Hi Arnaud,
> > >>PMD 4.1 has updated its deps (e.g. asm and jaxen), and I am concerned
on
> > >>upgrading the plugin.  I know you (and possibly others) spent
> > considerable
> > >>time aligning the dependencies amongst core and many other plugins.  I
> > >>know
> > >>Jaxen was one of them.
> > >>
> > >>Do you have concerns/suggestions on updating the plugin deps in this
> > >>manner
> > >>(e.g. jaxen from 1.1-beta-9 to 1.1.1)?
> > >>
> > >>
> > >>
> > >>
> > >>---------------------------------------------------------------------
> > >>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > >>For additional commands, e-mail: dev-help@maven.apache.org
> > >>
> > >>
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
> 
> 
> --
> ..........................................................
> Arnaud HERITIER
> ..........................................................
> OCTO Technology - aheritier AT octo DOT com
> www.octo.com | blog.octo.com
> ..........................................................
> ASF - aheritier AT apache DOT org
> www.apache.org | maven.apache.org
> ...........................................................



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: [m1] PMD plugin dependencies

Posted by Arnaud HERITIER <ah...@gmail.com>.
yes if you want. we can produce minor updates by upgrading some dependencies
if it helps to improve plugins.

Arnaud

On Nov 30, 2007 7:52 AM, Lukas Theussl <lt...@apache.org> wrote:

> Bad news: jaxen is used in the core [1]
> Good news: Arnaud had already upgraded a lot of deps and attached
> patches (MAVEN-1797 - 1805), among them for jaxen [2]
>
> Should we work on m1.1.1 with only upgraded deps?
>
> :)
> -Lukas
>
> [1] http://maven.apache.org/maven-1.x/dependencies.html
> [2] http://jira.codehaus.org/browse/MAVEN-1797
>
>
> Arnaud HERITIER wrote:
> > Hi jeff,
> >
> >   What you have to check, it is if jaxen is loaded by the core. If
> that's
> > the case, the version in the core is always used.
> >   If not, it is the version of jaxen used by the first plugin loaded
> which
> > use it.
> >   That's why we tried for the 1.1 release of maven to align dependencies
> to
> > have less side effects.
> >   I hope that 1.1.1 is compatible with 1.1-beta-9. Depending of the part
> of
> > jaxen which is used by pmd it's possible that it works fine with the old
> > version.
> >   If it's not the case you'll have to try to upgrade jaxen everywhere...
> >
> > Arnaud
> >
> > On Nov 30, 2007 2:05 AM, Jeff Jensen <je...@upstairstechnology.com>
> > wrote:
> >
> >
> >>Hi Arnaud,
> >>PMD 4.1 has updated its deps (e.g. asm and jaxen), and I am concerned on
> >>upgrading the plugin.  I know you (and possibly others) spent
> considerable
> >>time aligning the dependencies amongst core and many other plugins.  I
> >>know
> >>Jaxen was one of them.
> >>
> >>Do you have concerns/suggestions on updating the plugin deps in this
> >>manner
> >>(e.g. jaxen from 1.1-beta-9 to 1.1.1)?
> >>
> >>
> >>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >>For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >>
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

Re: [m1] PMD plugin dependencies

Posted by Lukas Theussl <lt...@apache.org>.
Bad news: jaxen is used in the core [1]
Good news: Arnaud had already upgraded a lot of deps and attached 
patches (MAVEN-1797 - 1805), among them for jaxen [2]

Should we work on m1.1.1 with only upgraded deps?

:)
-Lukas

[1] http://maven.apache.org/maven-1.x/dependencies.html
[2] http://jira.codehaus.org/browse/MAVEN-1797


Arnaud HERITIER wrote:
> Hi jeff,
> 
>   What you have to check, it is if jaxen is loaded by the core. If that's
> the case, the version in the core is always used.
>   If not, it is the version of jaxen used by the first plugin loaded which
> use it.
>   That's why we tried for the 1.1 release of maven to align dependencies to
> have less side effects.
>   I hope that 1.1.1 is compatible with 1.1-beta-9. Depending of the part of
> jaxen which is used by pmd it's possible that it works fine with the old
> version.
>   If it's not the case you'll have to try to upgrade jaxen everywhere...
> 
> Arnaud
> 
> On Nov 30, 2007 2:05 AM, Jeff Jensen <je...@upstairstechnology.com>
> wrote:
> 
> 
>>Hi Arnaud,
>>PMD 4.1 has updated its deps (e.g. asm and jaxen), and I am concerned on
>>upgrading the plugin.  I know you (and possibly others) spent considerable
>>time aligning the dependencies amongst core and many other plugins.  I
>>know
>>Jaxen was one of them.
>>
>>Do you have concerns/suggestions on updating the plugin deps in this
>>manner
>>(e.g. jaxen from 1.1-beta-9 to 1.1.1)?
>>
>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
> 
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org