You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "carryxyh (GitHub)" <gi...@apache.org> on 2018/10/09 07:01:46 UTC
[GitHub] [incubator-dubbo] carryxyh opened pull request #2624: Fix
incorrect descriptions for dubbo-serialization module for 2.6.x.
Fix incorrect descriptions for dubbo-serialization module for 2.6.x.
pr for master is here:
https://github.com/apache/incubator-dubbo/pull/2620
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2624 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2624: Fix
incorrect descriptions for dubbo-serialization module for 2.6.x.
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2624?src=pr&el=h1) Report
> Merging [#2624](https://codecov.io/gh/apache/incubator-dubbo/pull/2624?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/5adb9bfb59acdba3115f2b4cd1d9ec72ecec42cc?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2624?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #2624 +/- ##
============================================
+ Coverage 47.47% 47.48% +0.01%
- Complexity 4300 4302 +2
============================================
Files 557 557
Lines 24406 24406
Branches 4325 4325
============================================
+ Hits 11586 11590 +4
+ Misses 11020 11019 -1
+ Partials 1800 1797 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2624?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...aba/dubbo/remoting/transport/mina/MinaChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2624/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDaGFubmVsLmphdmE=) | `42.25% <0%> (-11.27%)` | `15% <0%> (-1%)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2624/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (ø)` | |
| [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2624/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | `8% <0%> (-1%)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2624/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `57.83% <0%> (+3.61%)` | `15% <0%> (+2%)` | :arrow_up: |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2624/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+5%)` | `21% <0%> (+1%)` | :arrow_up: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2624/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `73.07% <0%> (+7.69%)` | `8% <0%> (ø)` | :arrow_down: |
| [...va/com/alibaba/dubbo/config/DubboShutdownHook.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2624/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvRHViYm9TaHV0ZG93bkhvb2suamF2YQ==) | `73.91% <0%> (+30.43%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2624?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2624?src=pr&el=footer). Last update [5adb9bf...cabdbd1](https://codecov.io/gh/apache/incubator-dubbo/pull/2624?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2624 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh closed pull request #2624: Fix
incorrect descriptions for dubbo-serialization module for 2.6.x.
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
[ pull request closed by carryxyh ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2624 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] cvictory commented on issue #2624: Fix
incorrect descriptions for dubbo-serialization module for 2.6.x.
Posted by "cvictory (GitHub)" <gi...@apache.org>.
Ok, maybe we should post a issue for tracing the requirement and work.
At this time, I will add the pr description into 2.6.5 release note
directly.
时无两丶 <no...@github.com> 于2018年10月19日周五 下午4:44写道：
> @cvictory <https://github.com/cvictory>
> Hi,
> I am afraid not. This is a very small fix so there is no related issue,
> not even reviewed by others.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-dubbo/pull/2624#issuecomment-431290343>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AD5mbNIbNG-Ca5vJlIBqOiUXW9AHJeZIks5umZDggaJpZM4XRu2t>
> .
>
--
Best Regard!
cvitory
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2624 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2624: Fix
incorrect descriptions for dubbo-serialization module for 2.6.x.
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
@cvictory
Hi,
I am afraid not. This is a very small fix so there is no related issue, not even reviewed by others.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2624 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2624: Fix
incorrect descriptions for dubbo-serialization module for 2.6.x.
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Ok. I will do this now.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2624 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] carryxyh commented on issue #2624: Fix
incorrect descriptions for dubbo-serialization module for 2.6.x.
Posted by "carryxyh (GitHub)" <gi...@apache.org>.
Done.
Thx for reminding me.
:)
https://github.com/apache/incubator-dubbo/issues/2665
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2624 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] cvictory commented on issue #2624: Fix
incorrect descriptions for dubbo-serialization module for 2.6.x.
Posted by "cvictory (GitHub)" <gi...@apache.org>.
Is there a issue related to this pr?
I just collect the issues in 2.6.5 version.
时无两丶 <no...@github.com> 于2018年10月9日周二 下午3:16写道：
> Merged #2624 <https://github.com/apache/incubator-dubbo/pull/2624> into
> 2.6.x.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-dubbo/pull/2624#event-1891993581>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AD5mbLOArpSn7GWlTAkqVqqnBth3G2asks5ujE1FgaJpZM4XRu2t>
> .
>
--
Best Regard!
cvitory
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2624 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org