You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/10 09:36:09 UTC

[GitHub] [pulsar] Demogorgon314 commented on a diff in pull request #18392: [refactor][client] Remove duplicated and unused code in ACK grouping tracker

Demogorgon314 commented on code in PR #18392:
URL: https://github.com/apache/pulsar/pull/18392#discussion_r1018853908


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -57,6 +58,12 @@
 @Slf4j
 public class PersistentAcknowledgmentsGroupingTracker implements AcknowledgmentsGroupingTracker {
 
+    private static final TimedCompletableFuture<Void> COMPLETED_FUTURE = new TimedCompletableFuture<>();
+
+    static {
+        COMPLETED_FUTURE.complete(null);

Review Comment:
   Adding a `public static <U> TimedCompletableFuture<U> completedFuture(U value)` method in `TimedCompletableFuture` class might be better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org