You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/03/04 05:42:57 UTC
[kudu-CR] [ksck] field renamings: flags --> unusual flags
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15356
Change subject: [ksck] field renamings: flags_ --> unusual_flags_
......................................................................
[ksck] field renamings: flags_ --> unusual_flags_
Renamed:
flags_ --> unusual_flags_
flags_state_ --> unusual_flags_state_
In addition, this patch contains other unsorted re-factoring in the
same area of reporting on unusual flags.
A follow-up patch is based on this small re-factoring.
This changelist doesn't contain any functional modifications.
Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
4 files changed, 38 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15356/1
--
To view, visit http://gerrit.cloudera.org:8080/15356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
Gerrit-Change-Number: 15356
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [ksck] field renamings: flags --> unusual flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15356 )
Change subject: [ksck] field renamings: flags_ --> unusual_flags_
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15356/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15356/1//COMMIT_MSG@13
PS1, Line 13: unsorted
> assorted
Done
--
To view, visit http://gerrit.cloudera.org:8080/15356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
Gerrit-Change-Number: 15356
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 06:20:13 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ksck] field renamings: flags --> unusual flags
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15356 )
Change subject: [ksck] field renamings: flags_ --> unusual_flags_
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
Gerrit-Change-Number: 15356
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 06:58:14 +0000
Gerrit-HasComments: No
[kudu-CR] [ksck] field renamings: flags --> unusual flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15356
to look at the new patch set (#2).
Change subject: [ksck] field renamings: flags_ --> unusual_flags_
......................................................................
[ksck] field renamings: flags_ --> unusual_flags_
Renamed:
flags_ --> unusual_flags_
flags_state_ --> unusual_flags_state_
In addition, this patch contains other assorted re-factoring in the
same area of reporting on unusual flags.
A follow-up patch is based on this small re-factoring.
This changelist doesn't contain any functional modifications.
Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
4 files changed, 38 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15356/2
--
To view, visit http://gerrit.cloudera.org:8080/15356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
Gerrit-Change-Number: 15356
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [ksck] field renamings: flags --> unusual flags
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15356 )
Change subject: [ksck] field renamings: flags_ --> unusual_flags_
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15356/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15356/1//COMMIT_MSG@13
PS1, Line 13: unsorted
assorted
--
To view, visit http://gerrit.cloudera.org:8080/15356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
Gerrit-Change-Number: 15356
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 04 Mar 2020 05:56:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [ksck] field renamings: flags --> unusual flags
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15356 )
Change subject: [ksck] field renamings: flags_ --> unusual_flags_
......................................................................
[ksck] field renamings: flags_ --> unusual_flags_
Renamed:
flags_ --> unusual_flags_
flags_state_ --> unusual_flags_state_
In addition, this patch contains other assorted re-factoring in the
same area of reporting on unusual flags.
A follow-up patch is based on this small re-factoring.
This changelist doesn't contain any functional modifications.
Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
Reviewed-on: http://gerrit.cloudera.org:8080/15356
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
4 files changed, 38 insertions(+), 37 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f795ded086e70f145b2e86fdfaaf10135f66ce2
Gerrit-Change-Number: 15356
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)