You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/04/20 04:43:25 UTC

[GitHub] [couchdb] eiri commented on a change in pull request #2792: Make aegis into app and add key cache server

eiri commented on a change in pull request #2792:
URL: https://github.com/apache/couchdb/pull/2792#discussion_r411088960



##########
File path: src/aegis/src/aegis.erl
##########
@@ -14,44 +14,43 @@
 -include("aegis.hrl").
 -include_lib("fabric/include/fabric2.hrl").
 
-%% TODO - get from key manager
--define(ROOT_KEY, <<1:256>>).
 
 -define(WRAPPED_KEY, {?DB_AEGIS, 1}).
 
+-define(CACHE, aegis_key_cache).
+
 
 -export([
     create/2,
     open/2,
 
     decrypt/2,
     decrypt/3,
+    decrypt/4,
     encrypt/3,
+    encrypt/4,
     wrap_fold_fun/2
 ]).
 
-create(#{} = Db, Options) ->
+create(#{} = Db, _Options) ->

Review comment:
       Sure. How this option should be defined, based on parameter in default.ini or something else?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org