You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Christine Poerschke (JIRA)" <ji...@apache.org> on 2016/11/19 18:19:59 UTC
[jira] [Commented] (SOLR-9660) in GroupingSpecification factor
[group](sort|offset|limit) into [group](sortSpec)
[ https://issues.apache.org/jira/browse/SOLR-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15679654#comment-15679654 ]
Christine Poerschke commented on SOLR-9660:
-------------------------------------------
bq. ... this(sort, fields, DEFAULT_NUM, DEFAULT_OFFSET); ...
Usually I am a big fan of static constants like {{DEFAULT_NUM}}. However, here the existing default is {{10}} which to me at least seems a bit unexpected (why 10 and not 5 or 20 say?) and so I'd rather not introduce a DEFAULT_NUM=10 which would make the 10 more 'baked in' than it already is. (As a side note, the default value I would have expected is 0 because that clearly leaves it up to the constructing code to set a meaningful value. In my mind {{SortSpec}} is a 'library' data structure class and only 'application' classes would contain {{DEFAULT_NUM}} constants, and different 'application' classes might even contain different defaults.)
bq. ... 2-parameter version ... rewrite it in terms of a 4-parameter one ...
Good idea, I rebased and updated the patch to include a private implWeightSortSpec method and its logic is clearer since the three originalSortSpec.get... calls are pushed up into its caller.
> in GroupingSpecification factor [group](sort|offset|limit) into [group](sortSpec)
> ---------------------------------------------------------------------------------
>
> Key: SOLR-9660
> URL: https://issues.apache.org/jira/browse/SOLR-9660
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-9660.patch, SOLR-9660.patch, SOLR-9660.patch
>
>
> This is split out and adapted from and towards the SOLR-6203 changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org