You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jason Gerlowski (Jira)" <ji...@apache.org> on 2023/10/23 16:17:00 UTC
[jira] [Comment Edited] (SOLR-13528) Rate limiting in Solr
[ https://issues.apache.org/jira/browse/SOLR-13528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778728#comment-17778728 ]
Jason Gerlowski edited comment on SOLR-13528 at 10/23/23 4:16 PM:
------------------------------------------------------------------
This ticket added a {{SolrRequestType}} enum (with values "ADMIN", "QUERY", "UPDATE", etc).
It also added a string-returning {{getRequestType()}} method to the {{SolrRequest}} class. In all cases, {{getRequestType()}} returns a stringified value from the {{SolrRequestType}} enum. Does anyone with context recall why we have it return String instead of directly returning an enum value? (Maybe [~atri] or [~atris]?)
If the method was limited to returning enum values only, it would be a great way to simplify/remove some brittle SolrClient logic that attempts to identify "admin" requests from their HTTP path (see SOLR-17043). I'm interested in taking on that ticket but figured it'd be good to ask about the method first, in case folks with context here see a reason it wouldn't be a suitable approach...
was (Author: gerlowskija):
This ticket added a {{SolrRequestType}} enum (with values "ADMIN", "QUERY", "UPDATE", etc).
It also added a string-returning {{getRequestType()}} method to the {{SolrRequest}} class. In all cases, {{getRequestType()}} returns a stringified value from the {{SolrRequestType}} enum. Does anyone with context recall why we have it return String instead of directly returning an enum value? (Maybe [~atri] or [~atris]?)
If the method was limited to returning enum values only, it would be a great way to simplify/remove some brittle SolrClient logic that attempts to identify "admin" requests from their HTTP path (see SOLR-17043).
> Rate limiting in Solr
> ---------------------
>
> Key: SOLR-13528
> URL: https://issues.apache.org/jira/browse/SOLR-13528
> Project: Solr
> Issue Type: New Feature
> Reporter: Anshum Gupta
> Assignee: Atri Sharma
> Priority: Major
> Fix For: 9.0
>
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> In relation to SOLR-13527, Solr also needs a way to throttle update and search requests based on usage metrics. This is the umbrella JIRA for both update and search rate limiting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org