You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/08/22 17:21:11 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3708: HDDS-7159. Run integration tests on Java 8
adoroszlai opened a new pull request, #3708:
URL: https://github.com/apache/ozone/pull/3708
## What changes were proposed in this pull request?
Follow-up to #3707: run integration tests on Java 8. `TestSecureOzoneCluster` is failing on Java 11.
https://issues.apache.org/jira/browse/HDDS-7159
## How was this patch tested?
https://github.com/adoroszlai/hadoop-ozone/runs/7957021440?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kerneltime commented on a diff in pull request #3708: HDDS-7159. Run integration tests on Java 8
Posted by GitBox <gi...@apache.org>.
kerneltime commented on code in PR #3708:
URL: https://github.com/apache/ozone/pull/3708#discussion_r951832730
##########
.github/workflows/post-commit.yml:
##########
@@ -346,6 +346,10 @@ jobs:
maven-repo-${{ hashFiles('**/pom.xml') }}-8
maven-repo-${{ hashFiles('**/pom.xml') }}
maven-repo-
+ - name: Setup java
+ uses: actions/setup-java@v1
Review Comment:
Question: Looks like there are newer versions with better support for other JDKs and there is also https://github.com/oracle-actions/setup-java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] kaijchen commented on a diff in pull request #3708: HDDS-7159. Run integration tests on Java 8
Posted by GitBox <gi...@apache.org>.
kaijchen commented on code in PR #3708:
URL: https://github.com/apache/ozone/pull/3708#discussion_r952202696
##########
.github/workflows/post-commit.yml:
##########
@@ -346,6 +346,10 @@ jobs:
maven-repo-${{ hashFiles('**/pom.xml') }}-8
maven-repo-${{ hashFiles('**/pom.xml') }}
maven-repo-
+ - name: Setup java
+ uses: actions/setup-java@v1
Review Comment:
We can switch to [setup-java@v3](https://github.com/actions/setup-java#basic) later. And the `temurin` distribution seems more neutral.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3708: HDDS-7159. Run integration tests on Java 8
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3708:
URL: https://github.com/apache/ozone/pull/3708#discussion_r951857585
##########
.github/workflows/post-commit.yml:
##########
@@ -346,6 +346,10 @@ jobs:
maven-repo-${{ hashFiles('**/pom.xml') }}-8
maven-repo-${{ hashFiles('**/pom.xml') }}
maven-repo-
+ - name: Setup java
+ uses: actions/setup-java@v1
Review Comment:
We can check upgrade to v2 or v3 separately. I don't know if using oracle-actions is OK or not for Apache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3708: HDDS-7159. Run integration tests on Java 8
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3708:
URL: https://github.com/apache/ozone/pull/3708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3708: HDDS-7159. Run integration tests on Java 8
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3708:
URL: https://github.com/apache/ozone/pull/3708#issuecomment-1223621752
Thanks @kaijchen, @kerneltime for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org