[GitHub] [spark] jerrypeng commented on a diff in pull request #36090: [SPARK-38809][SS] Implement option to skip null values in symmetric hash implementation of stream-stream joins

[GitBox <gi...@apache.org>]

jerrypeng commented on code in PR #36090:
URL: https://github.com/apache/spark/pull/36090#discussion_r844496116


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1897,6 +1897,14 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  // SPARK-38809 - Config option to allow skipping null values for hash based stream-stream joins.

Review Comment:
   nit.  Can you briefly describe in what situations null can occur in stream-stream joins?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org