You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-commits@db.apache.org by bp...@apache.org on 2016/03/18 03:35:35 UTC

svn commit: r1735532 - in /db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc: schema/schema.sql utils/DbTasks.java utils/Statements.java

Author: bpendleton
Date: Fri Mar 18 02:35:35 2016
New Revision: 1735532

URL: http://svn.apache.org/viewvc?rev=1735532&view=rev
Log:
DERBY-4091: Investigate size_problem column in MailJdbc test

This patch was contributed by Sandeep Samdaria (ssamdar at ncsu dot edu)

This change removes the column size_problem from the inbox table used
by the MailJdbc test. Our investigation leads us to believe that this
column was in place to work around an old problem in Derby that no longer
exists, and is no longer needed.


Modified:
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/schema/schema.sql
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/DbTasks.java
    db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/Statements.java

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/schema/schema.sql
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/schema/schema.sql?rev=1735532&r1=1735531&r2=1735532&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/schema/schema.sql (original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/schema/schema.sql Fri Mar 18 02:35:35 2016
@@ -24,7 +24,6 @@ CREATE TABLE inbox (id bigint generated
 					folder_id Integer,
 					to_delete smallint default 0,
 					exp_date timestamp,
-					size_problem varchar(32672),
 					CONSTRAINT inbox__pk PRIMARY KEY (id));
 					
 CREATE TABLE attach (id bigint not null,

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/DbTasks.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/DbTasks.java?rev=1735532&r1=1735531&r2=1735532&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/DbTasks.java (original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/DbTasks.java Fri Mar 18 02:35:35 2016
@@ -459,11 +459,6 @@ public class DbTasks {
 					errorPrint(e);
 					throw e;
 				}
-				insertFirst
-						.setString(
-								5,
-								"This column is used only to by pass the space problem. If the problem still exists, then we are going to "
-										+ "have a serious issue here.*****************************************************************************************************");
 				int result = insertFirst.executeUpdate();
 				if (result != 0) {
 					insert_count = insert_count + 1;

Modified: db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/Statements.java
URL: http://svn.apache.org/viewvc/db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/Statements.java?rev=1735532&r1=1735531&r2=1735532&view=diff
==============================================================================
--- db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/Statements.java (original)
+++ db/derby/code/trunk/java/testing/org/apache/derbyTesting/system/mailjdbc/utils/Statements.java Fri Mar 18 02:35:35 2016
@@ -23,7 +23,7 @@ package org.apache.derbyTesting.system.m
 public class Statements {
 	public static String readStr = "select * from REFRESH.INBOX";
 
-	public static String insertStr = "insert into REFRESH.INBOX(from_name,to_name,date,Message,size_problem) values (?,?,?,?,?)";
+	public static String insertStr = "insert into REFRESH.INBOX(from_name,to_name,date,Message) values (?,?,?,?)";
 	
 	public static String insertStrAttach = "insert into REFRESH.ATTACH (id,attachment) values (?,?)";