You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by vinodkc <gi...@git.apache.org> on 2016/09/18 12:41:30 UTC

[GitHub] incubator-carbondata pull request #173: [CARBONDATA-256]Changed StringBuffer...

GitHub user vinodkc opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/173

    [CARBONDATA-256]Changed StringBuffer to StringBuilder

    Even with local variables of Stringbuffer type, unnecessary synchronization overhead will be added in string operation.Replacing StringBuffer with StringBuilder in such cases can avoid synchronization overhead
    
            - Whether new unit test cases have been added or why no new tests are required? 
               >> Not added new TCs . Not modified  any new functional change
    
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vinodkc/incubator-carbondata changeStringBufferToStringBuilder

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #173
    
----
commit 5401b825efad5ad650a06a9907c0e771e706ed5b
Author: vinodkc <vi...@gmail.com>
Date:   2016-09-18T12:18:44Z

    Changed StringBuffer to StringBuilder

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-carbondata pull request #173: [CARBONDATA-256]Changed StringBuffer...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/173


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---