You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/07 12:02:09 UTC

[GitHub] [apisix-dashboard] fregie commented on issue #1840: manager-api: Why putting the feature of daemon in core code?

fregie commented on issue #1840:
URL: https://github.com/apache/apisix-dashboard/issues/1840#issuecomment-834311829


   In file `api/cmd/service.go` and functions `newxxxCommand()` in `api/cmd/manageapi.go`.
   I don't think the code in these two files is necessary be added in the core code.It's fine just invoke `manageAPI()` in `manageapi.go` starting the service,and use a stand-alone script or something else to manage this service.
   On the other hand, this feature is redundant if it runs in a container.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org