[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #11851: [Fix] [Quartz] cron did not work as expected

[GitBox <gi...@apache.org>]

ruanwenjun commented on code in PR #11851:
URL: https://github.com/apache/dolphinscheduler/pull/11851#discussion_r966117212


##########
dolphinscheduler-api/src/main/resources/application.yaml:
##########
@@ -76,6 +76,7 @@ spring:
       org.quartz.scheduler.makeSchedulerThreadDaemon: true
       org.quartz.jobStore.driverDelegateClass: org.quartz.impl.jdbcjobstore.PostgreSQLDelegate
       org.quartz.jobStore.clusterCheckinInterval: 5000
+      org.quartz.scheduler.batchTriggerAcquisitionMaxCount: 20

Review Comment:
   In fact, we don't need to change the default value in standalone server, since the quartz will not startup in standalone server.



##########
dolphinscheduler-master/src/main/resources/application.yaml:
##########
@@ -64,10 +64,10 @@ spring:
       org.quartz.threadPool.makeThreadsDaemons: true
       org.quartz.threadPool.threadCount: 25
       org.quartz.jobStore.misfireThreshold: 60000
-      org.quartz.scheduler.batchTriggerAcquisitionMaxCount: 1
       org.quartz.scheduler.makeSchedulerThreadDaemon: true
       org.quartz.jobStore.driverDelegateClass: org.quartz.impl.jdbcjobstore.PostgreSQLDelegate
       org.quartz.jobStore.clusterCheckinInterval: 5000
+      org.quartz.scheduler.batchTriggerAcquisitionMaxCount: 20

Review Comment:
   And I don't think we need to change the default value of `org.quartz.scheduler.batchTriggerAcquisitionMaxCount`, this is the default value of quartz, and 20 is not the best one, the user still need to change if they need to have a higher output.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org