You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/25 12:47:00 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #458: Adding quick-view options to list view
davidjumani opened a new pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458
Fixes #449
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654905456
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-650287311
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654186086
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r450667877
##########
File path: src/components/view/ListView.vue
##########
@@ -61,18 +61,27 @@
-->
<span slot="name" slot-scope="text, record">
- <div style="min-width: 120px">
- <span v-if="$route.path.startsWith('/project')" style="margin-right: 5px">
- <a-button type="dashed" size="small" shape="circle" icon="login" @click="changeProject(record)" />
- </span>
- <os-logo v-if="record.ostypename" :osName="record.ostypename" size="1x" style="margin-right: 5px" />
- <console :resource="record" size="small" style="margin-right: 5px" />
+ <div style="min-width: 120px" >
+ <a-popover v-if="actions.length > 0" triggers="hover" placement="right">
Review comment:
@davidjumani for read-only admin will this hide the name if there is nothing to be shown? the hover part LGTM but it's not clear perhaps add an explicit icon; what about components which don't have name column as the first column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-656538566
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-652814497
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-651631833
@rhtyd @shwstppr good to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654270354
NOTE: Destory VM is broken as it destorys the first vm in the list and not the one to be destroyed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654952854
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-664176978
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-650342253
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r446282507
##########
File path: src/components/view/ListView.vue
##########
@@ -60,13 +60,22 @@
</div>
-->
+ <p v-if="actions.length > 0" :slot="actions.length > 0 ? 'expandedRowRender' : ''" slot-scope="record">
+ {{ record.id }}
+ <action-button
+ size="default"
+ :actions="$route.meta.actions"
+ :dataView="true"
+ :resource="record"
Review comment:
@davidjumani for some reason only the first row of the table is used when records are clicked/passed -> perhaps need refactoring - let's discuss next week
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-657969126
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2303)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654952522
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-650342642
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-653732948
Subjective/TBD - should we show labels for actions like legacy UI; should the quick view be in a pop/hover-over menu component? Or an icon you click (say the 3-dot icon, similar to chrome, android and other UXs) which shows the quick-view
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-665544826
let's discuss/address the issue icon and if we should show icons with labels @davidjumani ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-659302223
Ping @utchoang @ravening can you test as well, thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-650346642
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2148)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654912706
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2243)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-656542413
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2268)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani removed a comment on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani removed a comment on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654270354
NOTE: Any action which uses a custom view is broken. It picks up the first item in the list. Adding a `this.resource = action.resource` in execAction, AutogenView fixes it but have to look at potential side effects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-665574336
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654618481
Did a quick test LGTM, did not test for all possible cases; if there are issues we can restrict the quick view limited to only user facing views such as compute, storage, network, image etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-652278709
@davidjumani can you fix the conflict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654270354
NOTE: Any action which uses a custom view is broken. It picks up the first item in the list. Adding a `this.resource = action.resource` fixes it but have to look at potential side effects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-657966444
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-656538137
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-664176547
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r446289999
##########
File path: src/components/view/ListView.vue
##########
@@ -60,13 +60,22 @@
</div>
-->
+ <p v-if="actions.length > 0" :slot="actions.length > 0 ? 'expandedRowRender' : ''" slot-scope="record">
+ {{ record.id }}
+ <action-button
+ size="default"
+ :actions="$route.meta.actions"
+ :dataView="true"
+ :resource="record"
Review comment:
That was the case, so I changed the handleSubmit in Autogen.vue to read thre resource from the currentAction if present
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-652809847
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654905959
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r446289999
##########
File path: src/components/view/ListView.vue
##########
@@ -60,13 +60,22 @@
</div>
-->
+ <p v-if="actions.length > 0" :slot="actions.length > 0 ? 'expandedRowRender' : ''" slot-scope="record">
+ {{ record.id }}
+ <action-button
+ size="default"
+ :actions="$route.meta.actions"
+ :dataView="true"
+ :resource="record"
Review comment:
That was the case, so I changed the handleSubmit in Autogen.vue to read thre resource from the currentAction if present. Guess we might need to change the execAction too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654189817
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2221)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654560966
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654899804
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-655311154
@Pearl1594 can you review this thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani edited a comment on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654270354
NOTE: Any action which uses a custom view is broken. It picks up the first item in the list. Adding a `this.resource = action.resource` in execAction, AutogenView fixes it but have to look at potential side effects
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-650095426
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2141)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-652814314
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654185821
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-653341081
@rhtyd Good to go!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654957939
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2244)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r446289999
##########
File path: src/components/view/ListView.vue
##########
@@ -60,13 +60,22 @@
</div>
-->
+ <p v-if="actions.length > 0" :slot="actions.length > 0 ? 'expandedRowRender' : ''" slot-scope="record">
+ {{ record.id }}
+ <action-button
+ size="default"
+ :actions="$route.meta.actions"
+ :dataView="true"
+ :resource="record"
Review comment:
That was the case, so I changed the handleSubmit in Autogen.vue to read thre resource from the currentAction if present. Guess we might need other changes too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-657966697
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-652813352
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2186)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654093174
Please merge latest master and fix any conflicts? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r450625787
##########
File path: src/views/AutogenView.vue
##########
@@ -686,6 +687,8 @@ export default {
}
this.currentAction = action
this.currentAction.params = store.getters.apis[this.currentAction.api].params
+ this.resource = action.resource
+ this.$emit('change-resource', this.resource)
Review comment:
I'm not sure we'll have to explore/test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r462156240
##########
File path: src/components/view/QuickView.vue
##########
@@ -0,0 +1,85 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-popover v-if="enabled && actionsExist" triggers="hover" placement="right">
+ <template slot="content">
+ <action-button
+ :size="size"
+ :actions="actions"
+ :dataView="true"
+ :resource="resource"
+ @exec-action="execAction" />
+ </template>
+ <a-icon type="right-circle" style="margin-left: 5px" />
Review comment:
Could we use `<a-icon type="more" />` and use float:right to keep it at right most side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-664180857
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2655)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654899304
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654561394
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-650092324
@shwstppr a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] shwstppr commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-650091924
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-652817784
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2187)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-654563554
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/458 (JID-2228)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r462163271
##########
File path: src/components/view/QuickView.vue
##########
@@ -0,0 +1,85 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+<template>
+ <a-popover v-if="enabled && actionsExist" triggers="hover" placement="right">
+ <template slot="content">
+ <action-button
+ :size="size"
+ :actions="actions"
+ :dataView="true"
+ :resource="resource"
+ @exec-action="execAction" />
+ </template>
+ <a-icon type="right-circle" style="margin-left: 5px" />
Review comment:
Using the more icon doesn't look as good, it shows up very faint
Keeping it float right means that the user has to go to the rightmost end of the column to get the hover and back to the record name to get into the detail view. This way the icon is right after the name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r446302220
##########
File path: src/components/view/ListView.vue
##########
@@ -60,13 +60,22 @@
</div>
-->
+ <p v-if="actions.length > 0" :slot="actions.length > 0 ? 'expandedRowRender' : ''" slot-scope="record">
+ {{ record.id }}
+ <action-button
+ size="default"
+ :actions="$route.meta.actions"
+ :dataView="true"
+ :resource="record"
Review comment:
Changes made. Can test next week!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#discussion_r450577211
##########
File path: src/views/AutogenView.vue
##########
@@ -686,6 +687,8 @@ export default {
}
this.currentAction = action
this.currentAction.params = store.getters.apis[this.currentAction.api].params
+ this.resource = action.resource
+ this.$emit('change-resource', this.resource)
Review comment:
@rhtyd Is there a better way to ensure the right resource gets passed to the action form? The other changes made in b02a796c10780c1d63430ae7c1ff381dcdf0e539 only apprear to work for autogenerated forms
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-665574660
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #458: Adding quick-view options to list view
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #458:
URL: https://github.com/apache/cloudstack-primate/pull/458#issuecomment-652810157
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org