You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/04/29 22:50:21 UTC
Review Request 33685: DRILL-2904: Fix wrong "before rows" message to
"after rows" message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33685/
-----------------------------------------------------------
Review request for drill, Mehant Baid and Parth Chandra.
Bugs: DRILL-2904
https://issues.apache.org/jira/browse/DRILL-2904
Repository: drill-git
Description
-------
- Worked around Avatica isBeforeFirst()/next() bug.
- Fixed corresponding error in unit test.
- Also fixed other backwards test-failure message wording.
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java 2b20f23
exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java 64be408
Diff: https://reviews.apache.org/r/33685/diff/
Testing
-------
Manually checked (stepped through) unit test runs before and after fixing unit test.
Ran regular tests; no new failures.
Thanks,
Daniel Barclay
Re: Review Request 33685: DRILL-2904: Fix wrong "before rows" message
to "after rows" message
Posted by Parth Chandra <pc...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33685/#review82611
-----------------------------------------------------------
Ship it!
Ship It!
- Parth Chandra
On April 29, 2015, 8:50 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33685/
> -----------------------------------------------------------
>
> (Updated April 29, 2015, 8:50 p.m.)
>
>
> Review request for drill, Mehant Baid and Parth Chandra.
>
>
> Bugs: DRILL-2904
> https://issues.apache.org/jira/browse/DRILL-2904
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> - Worked around Avatica isBeforeFirst()/next() bug.
> - Fixed corresponding error in unit test.
> - Also fixed other backwards test-failure message wording.
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/AvaticaDrillSqlAccessor.java 2b20f23
> exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java 64be408
>
> Diff: https://reviews.apache.org/r/33685/diff/
>
>
> Testing
> -------
>
> Manually checked (stepped through) unit test runs before and after fixing unit test.
>
> Ran regular tests; no new failures.
>
>
> Thanks,
>
> Daniel Barclay
>
>