You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by rodms10 <gi...@git.apache.org> on 2014/06/11 01:18:34 UTC
[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...
GitHub user rodms10 opened a pull request:
https://github.com/apache/cordova-lib/pull/26
CB-6895 Add more config properties into manifest
Added `fullscreen`, `orientation` and `launch_path` to the manifest. Plus clean up and indentation. @zalun, can you take a look?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rodms10/cordova-lib CB-6895
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit 6cd02291983dd180412b93c62f7ca7476d8436d0
Author: Rodrigo Silveira <ro...@outlook.com>
Date: 2014-06-10T22:29:49Z
CB-6895 Add more config properties into manifest
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...
Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:
https://github.com/apache/cordova-lib/pull/26#issuecomment-45706042
r+ after answering the question of priority of the icons set
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...
Posted by zalun <gi...@git.apache.org>.
Github user zalun commented on the pull request:
https://github.com/apache/cordova-lib/pull/26#issuecomment-45991316
cool - I think we need to document it in details
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...
Posted by rodms10 <gi...@git.apache.org>.
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/26#issuecomment-45930663
Yeah, the priorities are pretty messy right now. Currently content in `config.xml` takes precedence on all manifest properties, except two: `permissions` and `icons`.
For icons we added config to `default.xml` which end up in your platform's `config.xml`. For permissions we update `plugin.xml` to add a `permission` element to the same platform's `config.xml`. The problem is that this file is recreated from scratch on every prepare. Which means you can't edit it.
Because those 2 properties do not take precedence, you can overwrite them on the manifest. But for that to work you need to create a manifest file in your root `www` folder or in `merges`.
You can edit your root `config.xml` to alter these properties too, like so:
``` xml
<platform name="firefoxos">
<permission description="Will be required for accessing user location." name="geolocation" />
<icon height="128" src="nonwicon/icon-128.png" width="128" />
<icon height="60" src="noneicon/icon-60.png" width="60" />
</platform>
```
This will create duplicates on the platform `config.xml`, that will come after whatever is defined in `defaults.xml` or `plugins.xml`. It will be ignored by current code since what comes first takes precedence.
That said, I think that editing the root `config.xml` should be the "official" way of changing those properties in the manifest and I made the changes to make it possible. The down side is that you can't overwrite them with a manifest anymore, but that is better aligned with cordova and removes the exceptions to precedence rules.
Note that I amended the commit to the last one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-6895 Add more config properties into ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/26
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---