You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by r7raul1984 <gi...@git.apache.org> on 2017/01/12 08:36:09 UTC
[GitHub] eagle pull request #772: [EAGLE-860] TopologyDataExtractor can't extract rig...
GitHub user r7raul1984 opened a pull request:
https://github.com/apache/eagle/pull/772
[EAGLE-860] TopologyDataExtractor can't extract right rack info
- Use clusternode API to get rack info.
https://issues.apache.org/jira/browse/EAGLE-860
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1haodian/eagle EAGLE-860
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/772.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #772
----
commit b2fa3af8308a92c3f9bbde36104a6b522574a1d9
Author: r7raul1984 <ta...@yhd.com>
Date: 2017-01-12T08:30:58Z
[EAGLE-860] TopologyDataExtractor can't extract right rack info
- Use clusternode API to get rack info.
https://issues.apache.org/jira/browse/EAGLE-860
commit e522c5ff26e3b980c42cff9b77bf3162a4ce303c
Author: r7raul1984 <ta...@yhd.com>
Date: 2017-01-12T08:33:53Z
Revert ui-build.sh
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #772: [EAGLE-860] TopologyDataExtractor can't extract rig...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/772#discussion_r95956231
--- Diff: eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/resolver/model/NodeInfo.java ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.eagle.topology.resolver.model;
+
+import org.codehaus.jackson.annotate.JsonIgnoreProperties;
--- End diff --
Please use `faster-xml jackson`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #772: [EAGLE-860] TopologyDataExtractor can't extract rig...
Posted by r7raul1984 <gi...@git.apache.org>.
Github user r7raul1984 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/772#discussion_r95956299
--- Diff: eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/resolver/model/NodeInfo.java ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.eagle.topology.resolver.model;
+
+import org.codehaus.jackson.annotate.JsonIgnoreProperties;
--- End diff --
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #772: [EAGLE-860] TopologyDataExtractor can't extract rig...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/eagle/pull/772
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #772: [EAGLE-860] TopologyDataExtractor can't extract right rack...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/772
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #772: [EAGLE-860] TopologyDataExtractor can't extract rig...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/772#discussion_r95956217
--- Diff: eagle-topology-check/eagle-topology-app/src/main/java/org/apache/eagle/topology/resolver/model/Node.java ---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.eagle.topology.resolver.model;
+
+import org.codehaus.jackson.annotate.JsonIgnoreProperties;
--- End diff --
Please use `faster-xml jackson`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---