You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/02/28 19:03:45 UTC
[GitHub] [mynewt-core] stuffmatic opened a new pull request #2509: bsp/stm32f4discovery: Add UART_1 support to enable logging using the ST-LINK virtual COM port
stuffmatic opened a new pull request #2509:
URL: https://github.com/apache/mynewt-core/pull/2509
This PR adds `UART_1` support by adding `os_bsp_uart1_cfg`, which uses `USART2`. This makes it possible to use the ST-LINK virtual COM port for logging if
1. Flying wires have been connected according to figure 6 (ST-LINK VCP connection to USART2) in the STM32F4DISCOVERY user manual
2. `UART_1` and `CONSOLE_UART_DEV` are set to `1` and `uart1` respectively
Below is the relevant page from the manual.
<img width="684" alt="Screenshot 2021-02-28 at 19 59 17" src="https://user-images.githubusercontent.com/2444852/109430038-71ee5c00-79ff-11eb-9858-d7da9b187b32.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2509: bsp/stm32f4discovery: Add UART_1 support to enable logging using the ST-LINK virtual COM port
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2509:
URL: https://github.com/apache/mynewt-core/pull/2509#issuecomment-787506216
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2509: bsp/stm32f4discovery: Add UART_1 support to enable logging using the ST-LINK virtual COM port
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2509:
URL: https://github.com/apache/mynewt-core/pull/2509#issuecomment-787505469
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/bsp/stm32f4discovery/src/hal_bsp.c
<details>
```diff
@@ -77,7 +77,7 @@
If flying wires are connected as in the discovery kit user manual
(Figure 6. ST-LINK VCP connection to USART2), logging via the ST-LINK
virtual COM port can be achieved by setting CONSOLE_UART_DEV to uart1.
-*/
+ */
const struct stm32_uart_cfg os_bsp_uart1_cfg = {
.suc_uart = USART2,
.suc_rcc_reg = &RCC->APB1ENR,
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2509: bsp/stm32f4discovery: Add UART_1 support to enable logging using the ST-LINK virtual COM port
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2509:
URL: https://github.com/apache/mynewt-core/pull/2509#issuecomment-787503846
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/bsp/stm32f4discovery/src/hal_bsp.c
<details>
```diff
@@ -73,9 +73,11 @@
#endif
#if MYNEWT_VAL(UART_1)
-// If flying wires are connected as in the discovery kit user manual
-// (Figure 6. ST-LINK VCP connection to USART2), logging via the ST-LINK
-// virtual COM port can be achieved by setting CONSOLE_UART_DEV to uart1.
+/*
+ If flying wires are connected as in the discovery kit user manual
+ (Figure 6. ST-LINK VCP connection to USART2), logging via the ST-LINK
+ virtual COM port can be achieved by setting CONSOLE_UART_DEV to uart1.
+ */
const struct stm32_uart_cfg os_bsp_uart1_cfg = {
.suc_uart = USART2,
.suc_rcc_reg = &RCC->APB1ENR,
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2509: bsp/stm32f4discovery: Add UART_1 support to enable logging using the ST-LINK virtual COM port
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2509:
URL: https://github.com/apache/mynewt-core/pull/2509#issuecomment-787505469
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/bsp/stm32f4discovery/src/hal_bsp.c
<details>
```diff
@@ -77,7 +77,7 @@
If flying wires are connected as in the discovery kit user manual
(Figure 6. ST-LINK VCP connection to USART2), logging via the ST-LINK
virtual COM port can be achieved by setting CONSOLE_UART_DEV to uart1.
-*/
+ */
const struct stm32_uart_cfg os_bsp_uart1_cfg = {
.suc_uart = USART2,
.suc_rcc_reg = &RCC->APB1ENR,
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2509: bsp/stm32f4discovery: Add UART_1 support to enable logging using the ST-LINK virtual COM port
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2509:
URL: https://github.com/apache/mynewt-core/pull/2509#issuecomment-787503846
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/bsp/stm32f4discovery/src/hal_bsp.c
<details>
```diff
@@ -73,9 +73,11 @@
#endif
#if MYNEWT_VAL(UART_1)
-// If flying wires are connected as in the discovery kit user manual
-// (Figure 6. ST-LINK VCP connection to USART2), logging via the ST-LINK
-// virtual COM port can be achieved by setting CONSOLE_UART_DEV to uart1.
+/*
+ If flying wires are connected as in the discovery kit user manual
+ (Figure 6. ST-LINK VCP connection to USART2), logging via the ST-LINK
+ virtual COM port can be achieved by setting CONSOLE_UART_DEV to uart1.
+ */
const struct stm32_uart_cfg os_bsp_uart1_cfg = {
.suc_uart = USART2,
.suc_rcc_reg = &RCC->APB1ENR,
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] kasjer merged pull request #2509: bsp/stm32f4discovery: Add UART_1 support to enable logging using the ST-LINK virtual COM port
Posted by GitBox <gi...@apache.org>.
kasjer merged pull request #2509:
URL: https://github.com/apache/mynewt-core/pull/2509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org