You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/05 05:22:29 UTC

[GitHub] [cloudstack] davidjumani opened a new pull request #5278: ui: Add 'on' to success status icon

davidjumani opened a new pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278


   ### Description
   
   Fixes https://github.com/apache/cloudstack/issues/5255
   
   Adds 'On' to the success case of the status icon
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [ ] Minor
   - [x] Trivial
   
   ### Screenshots (if appropriate):
   TODO


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893192965


   @davidjumani Off is not the default state I think. In code we have 4 states defined here, https://github.com/apache/cloudstack/blob/4.15/api/src/main/java/org/apache/cloudstack/outofbandmanagement/OutOfBandManagement.java#L90-L93


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez merged pull request #5278: ui: Add 'on / off' to status icon and make it case insensitive

Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5278: ui: Add 'on / off' to status icon and make it case insensitive

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893206425


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5278 (SL-JID-480)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893178720






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893183540


   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5278 (SL-JID-479)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5278: ui: Add 'on / off' to success status icon

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893200456


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5278: ui: Add 'on / off' to status icon and make it case insensitive

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893202670


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893175641






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5278: ui: Add 'on / off' to status icon and make it case insensitive

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893202820


   @shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893182050


   @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893178720


   @davidjumani conflicts here. And what about having it in 4.15?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893187420


   > @davidjumani can you please also add 'Off' state
   
   The default state is takes care of it (grey icon)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893175641


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893182050






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #5278: ui: Add 'on' to success status icon

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #5278:
URL: https://github.com/apache/cloudstack/pull/5278#issuecomment-893181894


   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org