You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2018/03/15 12:10:51 UTC
[kudu-CR] KUDU-2346: Fix mac pkg-config/PKG CONFIG PATH issue.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9652
to look at the new patch set (#2).
Change subject: KUDU-2346: Fix mac pkg-config/PKG_CONFIG_PATH issue.
......................................................................
KUDU-2346: Fix mac pkg-config/PKG_CONFIG_PATH issue.
Previously an empty return from pkg-config --cflags was used as a proxy for testing if the package was installed.
The Macos version of pkg-config returns an error message in response to this command when a package is not installed.
Fix is to use pkg-config --exixts which is designed for testing for this condition
Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
---
M thirdparty/build-thirdparty.sh
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/9652/2
--
To view, visit http://gerrit.cloudera.org:8080/9652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8a6b543dc65ac65d0dedf7e39f735b4805612bf1
Gerrit-Change-Number: 9652
Gerrit-PatchSet: 2
Gerrit-Owner: tigerquoll@outlook.com
Gerrit-Reviewer: Kudu Jenkins