[GitHub] [hive] ramesh0201 commented on a diff in pull request #3800: HIVE-26683: Sum windowing function returns wrong value when all nulls.

[GitBox <gi...@apache.org>]

ramesh0201 commented on code in PR #3800:
URL: https://github.com/apache/hive/pull/3800#discussion_r1038620035


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java:
##########
@@ -337,29 +345,35 @@ public GenericUDAFEvaluator getWindowingEvaluator(WindowFrameDef wFrameDef) {
         return null;
       }
 
-      return new GenericUDAFStreamingEvaluator.SumAvgEnhancer<HiveDecimalWritable, HiveDecimal>(
+      return new GenericUDAFStreamingEvaluator.SumAvgEnhancer<HiveDecimalWritable, Object[]>(

Review Comment:
   Hi @scarlin-cloudera Why are we changing this to Object[] instead of HiveDecimal and following places?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org