You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@fineract.apache.org by Myrle Krantz <mk...@mifos.org> on 2017/01/04 13:02:05 UTC
Re: [Apache Fineract] Addressing review comments of 0.5.0-incubating release
Hey Nazeer,
Keep in mind, that, if it's not about the license, you can usually treat
what our mentors and reviewers says as advice that we can follow or not.
We shouldn't automatically disregard their advice, because that would
impact their willingness to review our releases. But if the effort is
large, and the benefit small, no one is going to be offended if we say
"no", or "later". If our mentors aren't responding on this issue, it's
likely because it's not very important to them.
So we shouldn't let those points block our next release, but rather treat
them like any other ticket.
Greets,
Myrle
*Myrle Krantz*
Solutions Architect
RɅĐɅЯ, The Mifos Initiative
mkrantz@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org
<http://facebook.com/mifos> <http://www.twitter.com/mifos>
On Fri, Dec 30, 2016 at 11:12 AM, Shaik Nazeer <
nazeer.shaik@confluxtechnologies.com> wrote:
> Hi Fineract mentors,
>
>
>
> After analysing a bit, integrating RAT to top level directory is difficult
> as our complete build scripts are under sub directory.
>
> Either we need to add Gradle scripts to top level directory also or move
> the
> complete source tree from Fineract-provider to top level directory.
>
> I feel above two approaches area not good. So do you have any suggestions
> on
> this or shall I try to proceed with next release by adding "How to run RAT"
> in readme without integrating RAT to top level directory?
>
>
>
> And I don't understand how maven is going to help here as we are giving
> complete deployable war file.
>
>
>
> Can you let me know your opinion on this please.
>
>
>
> Thanks,
>
> Nazeer
>
> From: Shaik Nazeer [mailto:nazeer.shaik@confluxtechnologies.com]
> Sent: 29 December 2016 18:27
> To: dev@fineract.incubator.apache.org
> Subject: [Apache Fineract] Addressing review comments of 0.5.0-incubating
> release
>
>
>
> Hi all,
>
>
>
> I have created a JIRA task to address all review comments of
> 0.5.0-incubating release.
>
> https://issues.apache.org/jira/browse/FINERACT-357
>
>
>
> I can handle all review comments except maven related. Does anybody know
> how
> to include maven repo as part of Fineract release?
>
>
>
> Thanks
>
> Nazeer
>
>
Re: [Apache Fineract] Addressing review comments of 0.5.0-incubating
release
Posted by Jim Jagielski <ji...@jaguNET.com>.
+1 :)
> On Jan 6, 2017, at 5:20 AM, Myrle Krantz <mk...@mifos.org> wrote:
>
> Hey Nazeer,
>
> *I'm* sorry for expressing myself in a confusing manner. I didn't mean to
> imply you had done something wrong. You haven't.
>
> When I said "We shouldn't automatically disregard [our mentors] advice", I
> didn't mean to imply that you were. I was just setting the context for the
> suggestion that we *do* disregard their advice, but only on maven
> artifacts, and top-level RAT checks for the upcoming version.
>
> Hopefully I haven't made things even more confusing...
>
> Greets,
> Myrle
>
>
> *Myrle Krantz*
> Solutions Architect
> RɅĐɅЯ, The Mifos Initiative
> mkrantz@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org
> <http://facebook.com/mifos> <http://www.twitter.com/mifos>
>
>
> On Fri, Jan 6, 2017 at 8:22 AM, Nazeer Shaik <
> nazeer.shaik@confluxtechnologies.com> wrote:
>
>> Thank you Myrle. Sorry I was not disregarding mentors review comments
>> rather I was trying to get some help/opinion from all of you for the next
>> release.
>> I will go ahead with releasing 0.6.0-incubating today by mentioning the
>> same.
>>
>> Thanks,
>> Nazeer
>>
>> *Principal Architect, **Conflux Technologies Pvt Ltd
>> <http://www.confluxtechnologies.com/>*
>>
>> *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
>> Bengaluru, Karnataka, 560043 INDIA
>>
>>
>> Disclaimer: The information contained in this e-mail message and any
>> files/attachment transmitted with it is confidential and for the sole use
>> of the intended recipient(s) or entity identified. If you are not the
>> intended recipient, please email: support@confluxtechnologies.com and
>> destroy/delete all copies and attachment thereto along with the original
>> message. Any unauthorized review, use, disclosure, dissemination,
>> forwarding, printing or copying of this email or any action taken in
>> reliance on this e-mail is strictly prohibited and is unlawful. The
>> recipient acknowledges that Conflux Technologies Private Limited or its
>> subsidiaries and associated companies are unable to exercise control or
>> ensure or guarantee the integrity of/over the contents of the information
>> contained in e-mail transmissions. Before opening any attachments, please
>> check.
>>
>> On Wed, Jan 4, 2017 at 6:32 PM, Myrle Krantz <mk...@mifos.org> wrote:
>>
>>> Hey Nazeer,
>>>
>>> Keep in mind, that, if it's not about the license, you can usually treat
>>> what our mentors and reviewers says as advice that we can follow or not.
>>> We shouldn't automatically disregard their advice, because that would
>>> impact their willingness to review our releases. But if the effort is
>>> large, and the benefit small, no one is going to be offended if we say
>>> "no", or "later". If our mentors aren't responding on this issue, it's
>>> likely because it's not very important to them.
>>>
>>> So we shouldn't let those points block our next release, but rather treat
>>> them like any other ticket.
>>>
>>> Greets,
>>> Myrle
>>>
>>>
>>>
>>> *Myrle Krantz*
>>> Solutions Architect
>>> RɅĐɅЯ, The Mifos Initiative
>>> mkrantz@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org
>>> <http://facebook.com/mifos> <http://www.twitter.com/mifos>
>>>
>>>
>>> On Fri, Dec 30, 2016 at 11:12 AM, Shaik Nazeer <
>>> nazeer.shaik@confluxtechnologies.com> wrote:
>>>
>>>> Hi Fineract mentors,
>>>>
>>>>
>>>>
>>>> After analysing a bit, integrating RAT to top level directory is
>>> difficult
>>>> as our complete build scripts are under sub directory.
>>>>
>>>> Either we need to add Gradle scripts to top level directory also or
>> move
>>>> the
>>>> complete source tree from Fineract-provider to top level directory.
>>>>
>>>> I feel above two approaches area not good. So do you have any
>> suggestions
>>>> on
>>>> this or shall I try to proceed with next release by adding "How to run
>>> RAT"
>>>> in readme without integrating RAT to top level directory?
>>>>
>>>>
>>>>
>>>> And I don't understand how maven is going to help here as we are giving
>>>> complete deployable war file.
>>>>
>>>>
>>>>
>>>> Can you let me know your opinion on this please.
>>>>
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Nazeer
>>>>
>>>> From: Shaik Nazeer [mailto:nazeer.shaik@confluxtechnologies.com]
>>>> Sent: 29 December 2016 18:27
>>>> To: dev@fineract.incubator.apache.org
>>>> Subject: [Apache Fineract] Addressing review comments of
>> 0.5.0-incubating
>>>> release
>>>>
>>>>
>>>>
>>>> Hi all,
>>>>
>>>>
>>>>
>>>> I have created a JIRA task to address all review comments of
>>>> 0.5.0-incubating release.
>>>>
>>>> https://issues.apache.org/jira/browse/FINERACT-357
>>>>
>>>>
>>>>
>>>> I can handle all review comments except maven related. Does anybody
>> know
>>>> how
>>>> to include maven repo as part of Fineract release?
>>>>
>>>>
>>>>
>>>> Thanks
>>>>
>>>> Nazeer
>>>>
>>>>
>>>
>>
Re: [Apache Fineract] Addressing review comments of 0.5.0-incubating release
Posted by Myrle Krantz <mk...@mifos.org>.
Hey Nazeer,
*I'm* sorry for expressing myself in a confusing manner. I didn't mean to
imply you had done something wrong. You haven't.
When I said "We shouldn't automatically disregard [our mentors] advice", I
didn't mean to imply that you were. I was just setting the context for the
suggestion that we *do* disregard their advice, but only on maven
artifacts, and top-level RAT checks for the upcoming version.
Hopefully I haven't made things even more confusing...
Greets,
Myrle
*Myrle Krantz*
Solutions Architect
RɅĐɅЯ, The Mifos Initiative
mkrantz@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org
<http://facebook.com/mifos> <http://www.twitter.com/mifos>
On Fri, Jan 6, 2017 at 8:22 AM, Nazeer Shaik <
nazeer.shaik@confluxtechnologies.com> wrote:
> Thank you Myrle. Sorry I was not disregarding mentors review comments
> rather I was trying to get some help/opinion from all of you for the next
> release.
> I will go ahead with releasing 0.6.0-incubating today by mentioning the
> same.
>
> Thanks,
> Nazeer
>
> *Principal Architect, **Conflux Technologies Pvt Ltd
> <http://www.confluxtechnologies.com/>*
>
> *Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
> Bengaluru, Karnataka, 560043 INDIA
>
>
> Disclaimer: The information contained in this e-mail message and any
> files/attachment transmitted with it is confidential and for the sole use
> of the intended recipient(s) or entity identified. If you are not the
> intended recipient, please email: support@confluxtechnologies.com and
> destroy/delete all copies and attachment thereto along with the original
> message. Any unauthorized review, use, disclosure, dissemination,
> forwarding, printing or copying of this email or any action taken in
> reliance on this e-mail is strictly prohibited and is unlawful. The
> recipient acknowledges that Conflux Technologies Private Limited or its
> subsidiaries and associated companies are unable to exercise control or
> ensure or guarantee the integrity of/over the contents of the information
> contained in e-mail transmissions. Before opening any attachments, please
> check.
>
> On Wed, Jan 4, 2017 at 6:32 PM, Myrle Krantz <mk...@mifos.org> wrote:
>
> > Hey Nazeer,
> >
> > Keep in mind, that, if it's not about the license, you can usually treat
> > what our mentors and reviewers says as advice that we can follow or not.
> > We shouldn't automatically disregard their advice, because that would
> > impact their willingness to review our releases. But if the effort is
> > large, and the benefit small, no one is going to be offended if we say
> > "no", or "later". If our mentors aren't responding on this issue, it's
> > likely because it's not very important to them.
> >
> > So we shouldn't let those points block our next release, but rather treat
> > them like any other ticket.
> >
> > Greets,
> > Myrle
> >
> >
> >
> > *Myrle Krantz*
> > Solutions Architect
> > RɅĐɅЯ, The Mifos Initiative
> > mkrantz@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org
> > <http://facebook.com/mifos> <http://www.twitter.com/mifos>
> >
> >
> > On Fri, Dec 30, 2016 at 11:12 AM, Shaik Nazeer <
> > nazeer.shaik@confluxtechnologies.com> wrote:
> >
> > > Hi Fineract mentors,
> > >
> > >
> > >
> > > After analysing a bit, integrating RAT to top level directory is
> > difficult
> > > as our complete build scripts are under sub directory.
> > >
> > > Either we need to add Gradle scripts to top level directory also or
> move
> > > the
> > > complete source tree from Fineract-provider to top level directory.
> > >
> > > I feel above two approaches area not good. So do you have any
> suggestions
> > > on
> > > this or shall I try to proceed with next release by adding "How to run
> > RAT"
> > > in readme without integrating RAT to top level directory?
> > >
> > >
> > >
> > > And I don't understand how maven is going to help here as we are giving
> > > complete deployable war file.
> > >
> > >
> > >
> > > Can you let me know your opinion on this please.
> > >
> > >
> > >
> > > Thanks,
> > >
> > > Nazeer
> > >
> > > From: Shaik Nazeer [mailto:nazeer.shaik@confluxtechnologies.com]
> > > Sent: 29 December 2016 18:27
> > > To: dev@fineract.incubator.apache.org
> > > Subject: [Apache Fineract] Addressing review comments of
> 0.5.0-incubating
> > > release
> > >
> > >
> > >
> > > Hi all,
> > >
> > >
> > >
> > > I have created a JIRA task to address all review comments of
> > > 0.5.0-incubating release.
> > >
> > > https://issues.apache.org/jira/browse/FINERACT-357
> > >
> > >
> > >
> > > I can handle all review comments except maven related. Does anybody
> know
> > > how
> > > to include maven repo as part of Fineract release?
> > >
> > >
> > >
> > > Thanks
> > >
> > > Nazeer
> > >
> > >
> >
>
Re: [Apache Fineract] Addressing review comments of 0.5.0-incubating release
Posted by Nazeer Shaik <na...@confluxtechnologies.com>.
Thank you Myrle. Sorry I was not disregarding mentors review comments
rather I was trying to get some help/opinion from all of you for the next
release.
I will go ahead with releasing 0.6.0-incubating today by mentioning the
same.
Thanks,
Nazeer
*Principal Architect, **Conflux Technologies Pvt Ltd
<http://www.confluxtechnologies.com/>*
*Address*: #304, 2nd Floor, 7th Main Road, HRBR Layout 1st Block,
Bengaluru, Karnataka, 560043 INDIA
Disclaimer: The information contained in this e-mail message and any
files/attachment transmitted with it is confidential and for the sole use
of the intended recipient(s) or entity identified. If you are not the
intended recipient, please email: support@confluxtechnologies.com and
destroy/delete all copies and attachment thereto along with the original
message. Any unauthorized review, use, disclosure, dissemination,
forwarding, printing or copying of this email or any action taken in
reliance on this e-mail is strictly prohibited and is unlawful. The
recipient acknowledges that Conflux Technologies Private Limited or its
subsidiaries and associated companies are unable to exercise control or
ensure or guarantee the integrity of/over the contents of the information
contained in e-mail transmissions. Before opening any attachments, please
check.
On Wed, Jan 4, 2017 at 6:32 PM, Myrle Krantz <mk...@mifos.org> wrote:
> Hey Nazeer,
>
> Keep in mind, that, if it's not about the license, you can usually treat
> what our mentors and reviewers says as advice that we can follow or not.
> We shouldn't automatically disregard their advice, because that would
> impact their willingness to review our releases. But if the effort is
> large, and the benefit small, no one is going to be offended if we say
> "no", or "later". If our mentors aren't responding on this issue, it's
> likely because it's not very important to them.
>
> So we shouldn't let those points block our next release, but rather treat
> them like any other ticket.
>
> Greets,
> Myrle
>
>
>
> *Myrle Krantz*
> Solutions Architect
> RɅĐɅЯ, The Mifos Initiative
> mkrantz@mifos.org | Skype: mkrantz.mifos.org | http://mifos.org
> <http://facebook.com/mifos> <http://www.twitter.com/mifos>
>
>
> On Fri, Dec 30, 2016 at 11:12 AM, Shaik Nazeer <
> nazeer.shaik@confluxtechnologies.com> wrote:
>
> > Hi Fineract mentors,
> >
> >
> >
> > After analysing a bit, integrating RAT to top level directory is
> difficult
> > as our complete build scripts are under sub directory.
> >
> > Either we need to add Gradle scripts to top level directory also or move
> > the
> > complete source tree from Fineract-provider to top level directory.
> >
> > I feel above two approaches area not good. So do you have any suggestions
> > on
> > this or shall I try to proceed with next release by adding "How to run
> RAT"
> > in readme without integrating RAT to top level directory?
> >
> >
> >
> > And I don't understand how maven is going to help here as we are giving
> > complete deployable war file.
> >
> >
> >
> > Can you let me know your opinion on this please.
> >
> >
> >
> > Thanks,
> >
> > Nazeer
> >
> > From: Shaik Nazeer [mailto:nazeer.shaik@confluxtechnologies.com]
> > Sent: 29 December 2016 18:27
> > To: dev@fineract.incubator.apache.org
> > Subject: [Apache Fineract] Addressing review comments of 0.5.0-incubating
> > release
> >
> >
> >
> > Hi all,
> >
> >
> >
> > I have created a JIRA task to address all review comments of
> > 0.5.0-incubating release.
> >
> > https://issues.apache.org/jira/browse/FINERACT-357
> >
> >
> >
> > I can handle all review comments except maven related. Does anybody know
> > how
> > to include maven repo as part of Fineract release?
> >
> >
> >
> > Thanks
> >
> > Nazeer
> >
> >
>