You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/10/09 06:02:43 UTC
[GitHub] [incubator-kvrocks] aleksraiden opened a new pull request, #967: Add redis-benchmark to CI
aleksraiden opened a new pull request, #967:
URL: https://github.com/apache/incubator-kvrocks/pull/967
Add redis-benchmark and check it after all test passed. Draft #884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #967: Add redis-benchmark to CI
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #967:
URL: https://github.com/apache/incubator-kvrocks/pull/967#issuecomment-1282288860
Closed since I don't think this functionality should go into CI tasks per PR commit.
You may think of making a perf page like https://perf.rust-lang.org/ whose source is open. Or at least running a daily job while trying to post the result instead of bury them into CI output internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on pull request #967: Add redis-benchmark to CI
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on PR #967:
URL: https://github.com/apache/incubator-kvrocks/pull/967#issuecomment-1272464650
@torwig Could you please check my dirty Python and clean-up in? As I think we maybe can add all options from original redis-benchmark into options params to bench stage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on pull request #967: Add redis-benchmark to CI
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on PR #967:
URL: https://github.com/apache/incubator-kvrocks/pull/967#issuecomment-1272464380
Something wrong in CI-mode, when I try to start default kvrocks server from x.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] aleksraiden commented on pull request #967: Add redis-benchmark to CI
Posted by GitBox <gi...@apache.org>.
aleksraiden commented on PR #967:
URL: https://github.com/apache/incubator-kvrocks/pull/967#issuecomment-1272480171
@tisonkun thanks, correct, previously I see how to add new integration test with benchmark, but I'am not so perfect Go-dev )
If a path with bench-integration test in Go is more clear, I think, @torwig can help me in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #967: Add redis-benchmark to CI
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #967:
URL: https://github.com/apache/incubator-kvrocks/pull/967#issuecomment-1272464962
@aleksraiden I suggest you take a look at how `./x.py test go` implement. From my perspective, these two commands can be very similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun commented on pull request #967: Add redis-benchmark to CI
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #967:
URL: https://github.com/apache/incubator-kvrocks/pull/967#issuecomment-1272489897
@aleksraiden I don't mean you should use Golang here. I mean:
```
./x.py bench [BUILD] -p 6666 -q
# ^ optional binpath ^ rest parameters
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kvrocks] tisonkun closed pull request #967: Add redis-benchmark to CI
Posted by GitBox <gi...@apache.org>.
tisonkun closed pull request #967: Add redis-benchmark to CI
URL: https://github.com/apache/incubator-kvrocks/pull/967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org