You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2023/06/09 08:22:25 UTC

[GitHub] [ignite-3] tkalkirill opened a new pull request, #2173: IGNITE-19690 Get rid of configuration in MvTableStorage and related classes

tkalkirill opened a new pull request, #2173:
URL: https://github.com/apache/ignite-3/pull/2173

   https://issues.apache.org/jira/browse/IGNITE-19690


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] tkalkirill merged pull request #2173: IGNITE-19690 Get rid of configuration in MvTableStorage and related classes

Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #2173:
URL: https://github.com/apache/ignite-3/pull/2173


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2173: IGNITE-19690 Get rid of configuration in MvTableStorage and related classes

Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2173:
URL: https://github.com/apache/ignite-3/pull/2173#discussion_r1224220578


##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestStorageEngine.java:
##########
@@ -39,19 +39,16 @@ public String name() {
         return ENGINE_NAME;
     }
 
-    /** {@inheritDoc} */
     @Override
     public void start() throws StorageException {
         // No-op.
     }
 
-    /** {@inheritDoc} */
     @Override
     public void stop() throws StorageException {
         // No-op.
     }
 
-    /** {@inheritDoc} */
     @Override
     public MvTableStorage createMvTable(TableConfiguration tableCfg, TablesConfiguration tablesCfg,

Review Comment:
   Ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] rpuch commented on a diff in pull request #2173: IGNITE-19690 Get rid of configuration in MvTableStorage and related classes

Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2173:
URL: https://github.com/apache/ignite-3/pull/2173#discussion_r1224200155


##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestStorageEngine.java:
##########
@@ -39,19 +39,16 @@ public String name() {
         return ENGINE_NAME;
     }
 
-    /** {@inheritDoc} */
     @Override
     public void start() throws StorageException {
         // No-op.
     }
 
-    /** {@inheritDoc} */
     @Override
     public void stop() throws StorageException {
         // No-op.
     }
 
-    /** {@inheritDoc} */
     @Override
     public MvTableStorage createMvTable(TableConfiguration tableCfg, TablesConfiguration tablesCfg,

Review Comment:
   Do we still need `tableCfg` parameter here? It looks like we are only interested in table ID from it.
   
   Also, do we need `tablesCfg`?
   
   And what about distribution zone cfg: would it be better to pass some kind of config-agnostic object (zone descriptor?) containing partitions count (and something else, probably)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2173: IGNITE-19690 Get rid of configuration in MvTableStorage and related classes

Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #2173:
URL: https://github.com/apache/ignite-3/pull/2173#discussion_r1224219334


##########
modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestStorageEngine.java:
##########
@@ -39,19 +39,16 @@ public String name() {
         return ENGINE_NAME;
     }
 
-    /** {@inheritDoc} */
     @Override
     public void start() throws StorageException {
         // No-op.
     }
 
-    /** {@inheritDoc} */
     @Override
     public void stop() throws StorageException {
         // No-op.
     }
 
-    /** {@inheritDoc} */
     @Override
     public MvTableStorage createMvTable(TableConfiguration tableCfg, TablesConfiguration tablesCfg,

Review Comment:
   For now, I suggest leaving it as is in IGNITE-19483 will be changed to pass catalog descriptors instead of configuration.
   
   Instead of **tablesCfg** there will be either some temporary interface or a configuration will remain, I think it's more of an interface.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org