You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/18 19:47:25 UTC

[jira] [Commented] (FLINK-3781) BlobClient may be left unclosed in BlobCache#deleteGlobal()

    [ https://issues.apache.org/jira/browse/FLINK-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246122#comment-15246122 ] 

ASF GitHub Bot commented on FLINK-3781:
---------------------------------------

GitHub user gaoyike opened a pull request:

    https://github.com/apache/flink/pull/1907

    [FLINK-3781] BlobClient may be left unclosed in BlobCache#deleteGlobal()

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/flink release-1.0.2-rc3

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1907.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1907
    
----
commit f3c6646e68750a068b3325181b8a16a4689a0fed
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-22T17:37:59Z

    [hotfix] Make DataStream property methods properly Scalaesk
    
    This also includes some minor cleanups
    
    This closes #1689

commit df19a8bf908a21fc35830c08cc61d8d0566813eb
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-02-26T11:46:07Z

    [FLINK-3390] [runtime, tests] Restore savepoint path on ExecutionGraph restart
    
    Temporary work around to restore initial state on failure during recovery as
    required by a user. Will be superseded by FLINK-3397 with better handling of
    checkpoint and savepoint restoring.
    
    A failure during recovery resulted in restarting a job without its savepoint
    state. This temporary work around makes sure that if the savepoint coordinator
    ever restored a savepoint and there was no checkpoint after the savepoint,
    the savepoint state will be restored again.
    
    This closes #1720.

commit 8c3301501934ee0faeffec3f8c2034d292d078ef
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-26T14:12:07Z

    [FLINK-3522] [storm compat] PrintSampleStream prints a proper message when involked without arguments

commit c0bc8bcf7e1c3ac1f50c3038456f5af888392a06
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T10:57:21Z

    [hotfix] [build] Disable exclusion rules when using build-jar maven profile.
    
    This closes #1719

commit 2c605d275b26793d8676e35b6ccc5102bdcbf30d
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T13:08:02Z

    [FLINK-3511] [gelly] Introduce flink-gelly-examples module
    
    The new flink-gelly-examples module contains all Java and Scala Gelly examples. The module
    contains compile scope dependencies on flink-java, flink-scala and flink-clients so that
    the examples can be conveniently run from within the IDE.

commit 0601a762a4ee826bc628842e9b38f205fafdb76d
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-26T14:34:06Z

    [hotfix] Remove remaining unused files from the old standalone web client

commit 044479230e984b130f018930adaceb661c9aa80b
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T14:57:45Z

    [FLINK-3511] [avro] Move avro examples to test scope

commit f2de20b02bef66f437164e24e9fc0084530d4b01
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-26T17:19:27Z

    [FLINK-3525] [runtime] Fix call to super.close() in TimestampsAndPeriodicWatermarksOperator

commit 51ab77b16a994f2f511e34bb37f9c2294a234e50
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-26T17:31:32Z

    [license] Update LICENSE file for the latest version

commit 131f016e71540a5d1e264084c630b93de1aeabae
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T15:12:59Z

    [FLINK-3511] [hadoop-compatibility] Move hadoop-compatibility examples to test scope

commit 434cff00fd7fdc41dfb14f729888abaf12af1f7d
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T15:15:44Z

    [FLINK-3511] [jdbc] Move jdbc examples to test scope and add flink-clients dependency

commit 0dc824080f38d83d9a748d19d04344c3bf4d7077
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T15:21:13Z

    [FLINK-3511] [nifi, elasticsearch] Move nifi and elasticsearch examples to test scope

commit c0ce1b6d97bea3a938dc81454fcb17f373a58f12
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-26T15:27:06Z

    [FLINK-3511] [twitter] Move twitter examples to test scope
    
    This closes #1725

commit 603f351e2925aa4263a382b83cf41f12e8c5167f
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-26T19:06:06Z

    [FLINK-3526] [streaming] Fix Processing Time Window Assigner and Trigger
    
    This closes #1727

commit ba069f35b21de5d2a30ba0cd2234f20f35532c09
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-26T14:19:50Z

    [FLINK-3521] Make Iterable part of method signature for WindowFunction
    
    This closes #1723

commit 75e03caccad159fb04df4c7085a49d7f76e994c5
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-26T22:27:26Z

    [FLINK-3528] Add FoldingWindowBuffer for Non-Keyed Windows
    
    This makes AllWindowedStream.fold() take constant space, just like the
    keyed WindowOperator.
    
    Also this adds a new test case in EventTimeAllWindowCheckpointingITCase
    to verify that the FoldingWindowBuffer works.
    
    This also renames the preexisting window buffers to ReducingWindowBuffer
    and ListWindowBuffer to make the naming scheme consistent.

commit 1e2a9b825ec69cf1ae9e8441b154da2879285f3b
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-26T19:56:40Z

    [FLINK-3527] Add Scala DataStream.transform()
    
    This implicitly adds KeyedStream.transform() and also explicitly
    ConnectedStreams.transform().
    
    This also removes the transform exclusions from the API completeness
    tests.

commit eb164211ecde96bae106c7439364c4454d196df1
Author: Jark Wu <wu...@alibaba-inc.com>
Date:   2016-02-28T03:02:33Z

    [docs] fix typos in Basic Concepts documentation
    
    Closes #1730

commit 945f25b974f3773be31a108330d6cc5f7ec36235
Author: sahitya-pavurala <sa...@yahoo.com>
Date:   2016-02-24T02:08:23Z

    [FLINK-3461] [runtime] Remove redundant check in ZooKeeperLeaderElectionService
    
    This closes #1700.

commit a94aa9c6a7d47d8074120b77fe051f98931c11c6
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-02-25T23:11:48Z

    [FLINK-3517] [dist] Only count active PIDs in start script

commit 5b5136e9585a553485bc13abdfe3b8a6bd1805fc
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-02-29T11:01:10Z

    [FLINK-3532] [gelly] Fix artifact ID of flink-gelly-examples module
    
    The current flink-gelly-examples artifact id wrongly used an underscore to separate
    examples from flink-gelly. This commit replaces the underscore with an hyphen.
    
    This closes #1731.

commit 70262711641358dea28485c0c6926b1bea57bb95
Author: Stephan Ewen <se...@apache.org>
Date:   2016-02-29T15:24:47Z

    [docs] Update readme with current feature list and streaming example

commit 70ce072a484b0e4372f80f47440fdca702bb5042
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-02-29T14:37:45Z

    [FLINK-3534] [runtime] Prevent canceling Execution from failing
    
    This closes #1735.

commit 3adff87ddec7cb6c2aa29e4e23360e550ea8c118
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-02-29T13:14:35Z

    [FLINK-3535] [runtime-web] Decrease log verbosity of StackTraceSampleCoordinator
    
    This closes #1732.

commit 9b9f84e800b19b585e147ab6add4eb946356caa0
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-29T16:02:38Z

    [FLINK-3538] [api-breaking] Streamline Scala DataStream.join/coGroup
    
    This enforces that the user always has to specify keys for both inputs
    before .window() can be called.

commit ae5b4573b8e316042077ab85690d5d773c031865
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-29T13:56:29Z

    [FLINK-3536] Make clearer distinction between event time and processing time
    
    This brings it more in line with *ProcessingTimeWindows and makes it
    clear what type of window assigner it is.
    
    The old name, i.e. SlidingTimeWindows and TumblingTimeWindows is still
    available but deprecated.

commit 74c62b0b871d271f0dca18b88be64126a53774f6
Author: Robert Metzger <rm...@apache.org>
Date:   2016-02-29T15:13:02Z

    [FLINK-3540] Shade org.htrace in flink-shaded-hadoop to get rid of its Guava dependency
    
    This closes #1737

commit 30486905b81e9150b5efdc81defa98513c7032dc
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-29T19:20:07Z

    [FLINK-3548] [api-breaking] Remove unnecessary generic parameter from SingleOutputStreamOperator

commit 8e30f86657e4432a226d28810bac54cdcc906c04
Author: vasia <va...@apache.org>
Date:   2016-02-29T21:49:35Z

    [docs] fix readme typos; use the same scala style in the examples
    
    This closes #1743

commit 6262a0edde07f3ca968f88814e25927be7ed07c2
Author: Ufuk Celebi <uc...@apache.org>
Date:   2016-03-01T11:23:31Z

    [FLINK-3556] [runtime] Remove false check in HA blob store configuration
    
    This closes #1749.

----


> BlobClient may be left unclosed in BlobCache#deleteGlobal()
> -----------------------------------------------------------
>
>                 Key: FLINK-3781
>                 URL: https://issues.apache.org/jira/browse/FLINK-3781
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>   public void deleteGlobal(BlobKey key) throws IOException {
>     delete(key);
>     BlobClient bc = createClient();
>     bc.delete(key);
>     bc.close();
> {code}
> If delete() throws IOException, BlobClient would be left inclosed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)