[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4279: Spark: Allow Bin-Pack Rewrite between Partition Specs

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #4279:
URL: https://github.com/apache/iceberg/pull/4279#discussion_r820885166



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/Spark3BinPackStrategy.java
##########
@@ -67,12 +68,18 @@ public Table table() {
           .option(SparkReadOptions.FILE_OPEN_COST, "0")
           .load(table.name());
 
+      boolean requiresRepartition = !filesToRewrite.get(0).spec().equals(table.spec());

Review comment:
       Actual fix is here, everything else is test refactoring




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org