You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/10 17:12:51 UTC

[GitHub] [airflow] kaxil opened a new pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

kaxil opened a new pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685
 
 
   It is possible to assign a task to the dag using the bitshift operators, however it doesn't pick up default_args when done this way <https://issues.apache.org/jira/browse/AIRFLOW-883>:
   
   ```
   dag = DAG('my_dag', default_args=default_args)
   dummy = DummyOperator(task_id='dummy')
   
   dag >> dummy
   ```
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] eladkal commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685#issuecomment-597489146
 
 
   I think removing features like this one should be mentioned in `UPDATING.md`.
   Users who uses this feature will need to adjust their DAGs according to the change when upgrading.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685#issuecomment-597717437
 
 
   Restarted

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685#issuecomment-597578001
 
 
   > I think removing features like this one should be mentioned in `UPDATING.md`.
   > Users who uses this feature will need to adjust their DAGs according to the change when upgrading.
   
   Agree, fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] potiuk merged pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685#issuecomment-597714613
 
 
   FYI, CI failed without more detail, should restart it to retest

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on a change in pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685#discussion_r390711422
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/pubsub.py
 ##########
 @@ -196,8 +196,7 @@ class PubSubCreateSubscriptionOperator(BaseOperator):
 
         with DAG('failing DAG') as dag:
             (
-                dag
-                >> PubSubSubscriptionCreateOperator(
+                PubSubSubscriptionCreateOperator(
 
 Review comment:
   FYI, still have this syntax in line 44, 56, 185, 373, 382, 485, 496

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] kaxil commented on a change in pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685#discussion_r390903890
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/pubsub.py
 ##########
 @@ -196,8 +196,7 @@ class PubSubCreateSubscriptionOperator(BaseOperator):
 
         with DAG('failing DAG') as dag:
             (
-                dag
-                >> PubSubSubscriptionCreateOperator(
+                PubSubSubscriptionCreateOperator(
 
 Review comment:
   Fixed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] zhongjiajie commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685#issuecomment-597576746
 
 
   > I think removing features like this one should be mentioned in `UPDATING.md`.
   > Users who uses this feature will need to adjust their DAGs according to the change when upgrading.
   
   Make sence

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7685: [AIRFLOW-7034] Remove feature: Assigning Dag to task using Bitshift Op
URL: https://github.com/apache/airflow/pull/7685#issuecomment-597723193
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7685?src=pr&el=h1) Report
   > Merging [#7685](https://codecov.io/gh/apache/airflow/pull/7685?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/e6af02fdf4fa431739f49e444c93c54ca9f5a8e0?src=pr&el=desc) will **decrease** coverage by `0.29%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7685/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7685?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff            @@
   ##           master   #7685     +/-   ##
   ========================================
   - Coverage   86.99%   86.7%   -0.3%     
   ========================================
     Files         904     904             
     Lines       43728   43728             
   ========================================
   - Hits        38043   37916    -127     
   - Misses       5685    5812    +127
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7685?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/providers/google/cloud/operators/pubsub.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy9wdWJzdWIucHk=) | `90.69% <ø> (ø)` | :arrow_up: |
   | [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `96.46% <100%> (+0.12%)` | :arrow_up: |
   | [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.04% <100%> (-0.48%)` | :arrow_down: |
   | [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `88.33% <100%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0%> (-25.26%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | [airflow/utils/process\_utils.py](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9wcm9jZXNzX3V0aWxzLnB5) | `73.25% <0%> (-12.8%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7685/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7685?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7685?src=pr&el=footer). Last update [e6af02f...a695f27](https://codecov.io/gh/apache/airflow/pull/7685?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services