You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "GenerousMan (via GitHub)" <gi...@apache.org> on 2023/09/07 02:50:39 UTC
[GitHub] [rocketmq] GenerousMan opened a new pull request, #7320: [ISSUE #7319] Optimize fault-tolerant mechanism for sending messages and hot update switch
GenerousMan opened a new pull request, #7320:
URL: https://github.com/apache/rocketmq/pull/7320
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #7319
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] GenerousMan commented on pull request #7320: [ISSUE #7319] Optimize fault-tolerant mechanism for sending messages and hot update switch
Posted by "GenerousMan (via GitHub)" <gi...@apache.org>.
GenerousMan commented on PR #7320:
URL: https://github.com/apache/rocketmq/pull/7320#issuecomment-1709400589
@xdkxlk please help review~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #7320: [ISSUE #7319] Optimize fault-tolerant mechanism for sending messages and hot update switch
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7320:
URL: https://github.com/apache/rocketmq/pull/7320#issuecomment-1709413151
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7320?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#7320](https://app.codecov.io/gh/apache/rocketmq/pull/7320?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (48c6d4f) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/e11e29419f6e2d1d9673d0329e57b824ebf3da47?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (e11e294) will **decrease** coverage by `0.05%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #7320 +/- ##
=============================================
- Coverage 42.69% 42.64% -0.05%
+ Complexity 9474 9468 -6
=============================================
Files 1152 1152
Lines 82721 82731 +10
Branches 10781 10783 +2
=============================================
- Hits 35315 35280 -35
- Misses 42997 43046 +49
+ Partials 4409 4405 -4
```
| [Files Changed](https://app.codecov.io/gh/apache/rocketmq/pull/7320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ocketmq/proxy/service/route/TopicRouteService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7320?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2Uvcm91dGUvVG9waWNSb3V0ZVNlcnZpY2UuamF2YQ==) | `45.88% <0.00%> (-6.12%)` | :arrow_down: |
... and [17 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/7320/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xdkxlk merged pull request #7320: [ISSUE #7319] Optimize fault-tolerant mechanism for sending messages and hot update switch
Posted by "xdkxlk (via GitHub)" <gi...@apache.org>.
xdkxlk merged PR #7320:
URL: https://github.com/apache/rocketmq/pull/7320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] xdkxlk commented on a diff in pull request #7320: [ISSUE #7319] Optimize fault-tolerant mechanism for sending messages and hot update switch
Posted by "xdkxlk (via GitHub)" <gi...@apache.org>.
xdkxlk commented on code in PR #7320:
URL: https://github.com/apache/rocketmq/pull/7320#discussion_r1318164831
##########
client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java:
##########
@@ -37,6 +37,8 @@ public class LatencyFaultToleranceImpl implements LatencyFaultTolerance<String>
private int detectTimeout = 200;
private int detectInterval = 2000;
private final ThreadLocalIndex whichItemWorst = new ThreadLocalIndex();
+
+ private boolean startDetectorEnable = false;
Review Comment:
It is better to use volatile here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org