You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/16 21:28:41 UTC
[GitHub] [arrow] lidavidm opened a new pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
lidavidm opened a new pull request #12650:
URL: https://github.com/apache/arrow/pull/12650
Also, report errors in integration tests to the client.
Hopefully, this will make debugging ARROW-15953 easier if we can
catch it happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#issuecomment-1076741477
Benchmark runs are scheduled for baseline = a95d6889b8275ef0a40a441ade292d40fa078390 and contender = 18e7cbf75f9b2cb58571a33f0dbd8b4ed954f23b. 18e7cbf75f9b2cb58571a33f0dbd8b4ed954f23b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3153bed2134445e38b9852350a31d6ca...dca3dcb8c6a8497aa8c93eda355cc15b/)
[Finished :arrow_down:0.17% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fa94676030ab43d0853639d2dc9d728b...359cafa00a8049239d7b18d772ce4d50/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/adb5ef42d36a4fa0a8d6089e597657cf...af2734c3bc69480cb1c218ef3b00c284/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/810306916e9b4c5bb3884841691a0935...e5ae95cd17ae4c558a0aad259f5c2fc6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#discussion_r829973745
##########
File path: java/flight/flight-core/README.md
##########
@@ -23,73 +23,4 @@ Exposing Apache Arrow data on the wire.
[Protocol Description Slides](https://www.slideshare.net/JacquesNadeau5/apache-arrow-flight-overview)
-[GRPC Protocol Definition](https://github.com/apache/arrow/blob/master/format/Flight.proto)
-
-## Example usage
Review comment:
It's not, I removed all the old 'example' code in favor of keeping things in the cookbook; also I don't think we should be steering people towards generating Protobuf/gRPC stubs here. That said I just updated it to actually link to the cookbook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#discussion_r829715687
##########
File path: java/flight/flight-core/README.md
##########
@@ -23,73 +23,4 @@ Exposing Apache Arrow data on the wire.
[Protocol Description Slides](https://www.slideshare.net/JacquesNadeau5/apache-arrow-flight-overview)
-[GRPC Protocol Definition](https://github.com/apache/arrow/blob/master/format/Flight.proto)
-
-## Example usage
Review comment:
this is no longer accurate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#issuecomment-1069654079
https://issues.apache.org/jira/browse/ARROW-15956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#discussion_r829973745
##########
File path: java/flight/flight-core/README.md
##########
@@ -23,73 +23,4 @@ Exposing Apache Arrow data on the wire.
[Protocol Description Slides](https://www.slideshare.net/JacquesNadeau5/apache-arrow-flight-overview)
-[GRPC Protocol Definition](https://github.com/apache/arrow/blob/master/format/Flight.proto)
-
-## Example usage
Review comment:
It's not, I removed all the old 'example' code in favor of keeping things in the cookbook; also I don't think we should be steering people towards generating Protobuf/gRPC stubs here. That said I just updated it to actually link to the cookbook.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12650:
URL: https://github.com/apache/arrow/pull/12650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#issuecomment-1076741477
Benchmark runs are scheduled for baseline = a95d6889b8275ef0a40a441ade292d40fa078390 and contender = 18e7cbf75f9b2cb58571a33f0dbd8b4ed954f23b. 18e7cbf75f9b2cb58571a33f0dbd8b4ed954f23b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3153bed2134445e38b9852350a31d6ca...dca3dcb8c6a8497aa8c93eda355cc15b/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fa94676030ab43d0853639d2dc9d728b...359cafa00a8049239d7b18d772ce4d50/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/adb5ef42d36a4fa0a8d6089e597657cf...af2734c3bc69480cb1c218ef3b00c284/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/810306916e9b4c5bb3884841691a0935...e5ae95cd17ae4c558a0aad259f5c2fc6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#issuecomment-1076741477
Benchmark runs are scheduled for baseline = a95d6889b8275ef0a40a441ade292d40fa078390 and contender = 18e7cbf75f9b2cb58571a33f0dbd8b4ed954f23b. 18e7cbf75f9b2cb58571a33f0dbd8b4ed954f23b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3153bed2134445e38b9852350a31d6ca...dca3dcb8c6a8497aa8c93eda355cc15b/)
[Finished :arrow_down:0.17% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fa94676030ab43d0853639d2dc9d728b...359cafa00a8049239d7b18d772ce4d50/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/adb5ef42d36a4fa0a8d6089e597657cf...af2734c3bc69480cb1c218ef3b00c284/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/810306916e9b4c5bb3884841691a0935...e5ae95cd17ae4c558a0aad259f5c2fc6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on a change in pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
emkornfield commented on a change in pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#discussion_r829715687
##########
File path: java/flight/flight-core/README.md
##########
@@ -23,73 +23,4 @@ Exposing Apache Arrow data on the wire.
[Protocol Description Slides](https://www.slideshare.net/JacquesNadeau5/apache-arrow-flight-overview)
-[GRPC Protocol Definition](https://github.com/apache/arrow/blob/master/format/Flight.proto)
-
-## Example usage
Review comment:
this is no longer accurate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12650: ARROW-15956: [Java] Consolidate Flight integration testing code
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12650:
URL: https://github.com/apache/arrow/pull/12650#issuecomment-1076741477
Benchmark runs are scheduled for baseline = a95d6889b8275ef0a40a441ade292d40fa078390 and contender = 18e7cbf75f9b2cb58571a33f0dbd8b4ed954f23b. 18e7cbf75f9b2cb58571a33f0dbd8b4ed954f23b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3153bed2134445e38b9852350a31d6ca...dca3dcb8c6a8497aa8c93eda355cc15b/)
[Finished :arrow_down:0.17% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fa94676030ab43d0853639d2dc9d728b...359cafa00a8049239d7b18d772ce4d50/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/adb5ef42d36a4fa0a8d6089e597657cf...af2734c3bc69480cb1c218ef3b00c284/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/810306916e9b4c5bb3884841691a0935...e5ae95cd17ae4c558a0aad259f5c2fc6/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org