You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/03 23:47:23 UTC

[GitHub] [spark] vanzin commented on a change in pull request #28019: [SPARK-31021][SQL] Support MariaDB Kerberos login in JDBC connector

vanzin commented on a change in pull request #28019: [SPARK-31021][SQL] Support MariaDB Kerberos login in JDBC connector
URL: https://github.com/apache/spark/pull/28019#discussion_r403384569
 
 

 ##########
 File path: external/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/DB2IntegrationSuite.scala
 ##########
 @@ -41,6 +41,7 @@ class DB2IntegrationSuite extends DockerJDBCIntegrationSuite {
     override val jdbcPort: Int = 50000
     override def getJdbcUrl(ip: String, port: Int): String =
       s"jdbc:db2://$ip:$port/foo:user=db2inst1;password=rootpass;retrieveMessagesFromServerOnGetMessage=true;" //scalastyle:ignore
+    override def getEntryPoint: Option[String] = None
 
 Review comment:
   Why not have this in the base class and only override where needed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org