You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2014/06/04 14:41:39 UTC

[GitHub] incubator-storm pull request: Fix for STORM-244 DRPC timeout can r...

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/incubator-storm/pull/132#discussion_r13383216
  
    --- Diff: storm-core/test/clj/backtype/storm/drpc_test.clj ---
    @@ -218,3 +220,13 @@
         (.shutdown cluster)
         (.shutdown drpc)
         ))
    +
    +(deftest test-drpc-timeout-cleanup 
    +  (let [queue (ConcurrentLinkedQueue.)
    +        delay-seconds 2]
    --- End diff --
    
    Why 2 instead of 1? Also could we stub TIMEOUT-CHECK-SECS to something smaller like 1 so that the test can run faster?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---