You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2025/02/01 00:21:42 UTC
Re: [PR] feat(filter): adding inputs to Numerical Range Filter [superset]
villebro commented on PR #31726:
URL: https://github.com/apache/superset/pull/31726#issuecomment-2628610093
@alexandrusoare I don't fully agree with the new UX. Currently when the filter renders, it shows the min and max values as set, despite them not applying to any charts (see how the filter indicator is unset):
<img width="731" alt="image" src="https://github.com/user-attachments/assets/dfb10374-a2e5-4e23-93ac-89972ed24b4a" />
In this example, the minimum and maximum values of the reference column are 5 and 37296 respectively. When I bump the lower bound from 5 to 6, it starts applying the lower bound (setting it explicitly to a value that's lower than the min value removes the bound):
<img width="729" alt="image" src="https://github.com/user-attachments/assets/2b495795-ed2a-4f26-852f-3f082fd7c208" />
The same happens for the upper bound.
It feels like it would be more intuitive if the min/max values were shown as placeholders when the lower/upper bounds are unset, and only when a value is entered, the value would apply. With this change it would also be possible to explicitly set a lower/upper bound when it coincides with the min/max.
Thoughts? Ping @kgabryje @kasiazjc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org